internal/dag: Fix for duplicate include detection #5296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we have an include on a certain path, then a different valid include condition on that same path, duplicates of the later include conditions were not detected. Signed-off-by: Sunjay Bhatia <[email protected]>
sunjayBhatia
added
the
release-note/small
sunjayBhatia
requested review from
tsaarni,
stevesloka and
skriss
and removed request for
a team
Signed-off-by: Sunjay Bhatia <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5296 +/- ##
=======================================
Coverage 77.74% 77.75%
=======================================
Files 139 139
Lines 18073 18081 +8
=======================================
+ Hits 14051 14059 +8
Misses 3750 3750
Partials 272 272
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have an include on a certain path, then a different valid include condition on that same path, duplicates of the later include conditions were not detected.
This actually does not need to be backported to the 1.24 release as that introduced the improved duplicate detection behavior, but did add the seen path/header conditions to the map, see here: https://github.com/projectcontour/contour/blob/v1.24.3/internal/dag/httpproxy_processor.go#L1441