Skip to content

Conversation

pnbrown
Copy link

@pnbrown pnbrown commented Mar 6, 2023

Move Steve to Tech Lead and Nick Young to Emeritus Maintainer.

@pnbrown pnbrown requested a review from a team as a code owner March 6, 2023 20:35
@pnbrown pnbrown requested review from tsaarni and stevesloka and removed request for a team March 6, 2023 20:35
@pnbrown pnbrown added the release-note/docs A documentation change for the release notes. label Mar 6, 2023
@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Merging #5151 (30d1821) into main (1302568) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5151   +/-   ##
=======================================
  Coverage   77.96%   77.96%           
=======================================
  Files         138      138           
  Lines       17509    17509           
=======================================
  Hits        13651    13651           
  Misses       3592     3592           
  Partials      266      266           

@pnbrown pnbrown force-pushed the front-page-update branch 2 times, most recently from 5c248d6 to 3acf370 Compare March 6, 2023 21:27
Copy link
Member

@tsaarni tsaarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

One question: I assume it was agreed that Nick is not removed from the web site? I ask, because there have been cases before where emeritus maintainers were "moved" to this file from the web page https://github.com/projectcontour/community/blob/main/MAINTAINERS.md

Copy link
Member

@sunjayBhatia sunjayBhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah @tsaarni has a point about keeping the front page for active maintainers

fine with either way, but if we want to keep emeritus maintainers here we probably should bring back others for consistency, probably easier to leave the emeritus maintainers in the community repo

@sunjayBhatia sunjayBhatia requested a review from skriss March 7, 2023 18:01
@skriss
Copy link
Member

skriss commented Mar 7, 2023

+1, I think we can drop Nick here for consistency since he's still listed in the community repo.

Add release note file

Move Steve to Tech Lead and Nick Young to Emeritus Maintainer.

Signed-off-by: Nigel Brown <[email protected]>
@pnbrown pnbrown force-pushed the front-page-update branch from 3acf370 to 30d1821 Compare March 7, 2023 20:24
@pnbrown
Copy link
Author

pnbrown commented Mar 7, 2023

Understood. That change is made.

@skriss skriss merged commit 3448e3a into projectcontour:main Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/docs A documentation change for the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants