Skip to content

Gateway API: always set ResolvedRefs condition #5131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 2, 2023
Merged

Gateway API: always set ResolvedRefs condition #5131

merged 4 commits into from
Mar 2, 2023

Conversation

izturn
Copy link
Member

@izturn izturn commented Mar 1, 2023

Signed-off-by: Gang Liu [email protected]

fix #5065

izturn added 2 commits March 1, 2023 09:52
@izturn izturn requested a review from a team as a code owner March 1, 2023 03:29
@izturn izturn requested review from tsaarni and skriss and removed request for a team March 1, 2023 03:29
@codecov
Copy link

codecov bot commented Mar 1, 2023 •
edited
Loading

Codecov Report

Merging #5131 (0360c87) into main (b461e76) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5131      +/-   ##
==========================================
+ Coverage   78.01%   78.02%   +0.01%     
==========================================
  Files         138      138              
  Lines       17509    17517       +8     
==========================================
+ Hits        13660    13668       +8     
  Misses       3583     3583              
  Partials      266      266
Impacted Files Coverage Δ
internal/dag/gatewayapi_processor.go 95.10% <100.00%> (+<0.01%) ⬆️
internal/status/routeconditions.go 53.92% <100.00%> (+2.87%) ⬆️

skriss
skriss requested changes Mar 1, 2023
View reviewed changes
Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @izturn!

@izturn izturn requested a review from skriss March 2, 2023 06:08
@izturn
add change log
0360c87 
Signed-off-by: Gang Liu <[email protected]>
@skriss skriss added the release-note/small A small change that needs one line of explanation in the release notes. label Mar 2, 2023
@skriss skriss requested a review from sunjayBhatia March 2, 2023 15:18
skriss
skriss approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will leave for @sunjayBhatia to take a look as well

@skriss skriss merged commit bfdf1c4 into projectcontour:main Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skriss skriss skriss approved these changes

@sunjayBhatia sunjayBhatia sunjayBhatia approved these changes

@tsaarni tsaarni Awaiting requested review from tsaarni tsaarni is a code owner automatically assigned from projectcontour/maintainers

Assignees
No one assigned
Labels
release-note/small A small change that needs one line of explanation in the release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gateway API: always set ResolvedRefs condition, even if true
3 participants
@izturn @skriss @sunjayBhatia