Update for Blacklight 8.12.0 #3532
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylor-steve
force-pushed
the
test-fixes
branch
from
35966e8 to
9d23f96
Compare
taylor-steve
force-pushed
the
test-fixes
branch
from
48eb12b to
a4507aa
Compare
|
Most of these changes seem to be related to view_component 4.0, not Blacklight 8.12. |
jcoyne
reviewed
Aug 12, 2025
| @@ -4,6 +4,7 @@ module Spotlight | |||
| ## | |||
| # Exhibit resources | |||
| class Resource < ActiveRecord::Base | |||
| # rubocop:disable Style/RedundantParentheses | |||
There was a problem hiding this comment.
Is there a reason not to remove the redundant parenthesis?
There was a problem hiding this comment.
Yes, it changes the behavior (in the way rubocop wants to remove them)
There was a problem hiding this comment.
That sounds like a bug in rubocop. Have you filed an issue? They are usually responsive to fixing these sorts of things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rubocop + Blacklight 8.12.0 changes