Skip to content

Resolve mobile limits/facet toggle alignment #1959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 3, 2018
Merged

Resolve mobile limits/facet toggle alignment #1959

merged 2 commits into from
Aug 3, 2018

Conversation

ewlarson
Copy link
Contributor

Fixes #1957 Reflow #facets children for Bootstrap 4's .navbar expectactions.

Fixes #1957  Reflow #facets children for Bootstrap 4's .navbar expectactions.
@coveralls
Copy link

coveralls commented Jul 30, 2018

Coverage Status

Coverage increased (+0.09%) to 94.663% when pulling 214e0f2 on ewlarson:1957-mobile-limit-toggle-redux into 99878d4 on projectblacklight:master.

@jcoyne
Copy link
Member

jcoyne commented Jul 30, 2018

Should we remove the top-panel-heading styles from _facets.scss?

Styles for .top-panel-heading no longer needed with BS4 .navbar

Co-Authored-By: Justin Coyne <[email protected]>
Copy link
Contributor

@mejackreed mejackreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job. Working great for me.

screen shot 2018-08-03 at 9 28 35 am

@mejackreed mejackreed merged commit 253d09f into projectblacklight:master Aug 3, 2018
ConnorSheremeta added a commit to ConnorSheremeta/blacklight that referenced this pull request May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants