Skip to content

Conversation

@AndrewWestberg
Copy link
Member

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a Kogmios shutdown hang issue (STUD-499) by removing blocking await calls for receive and send operations during WebSocket closure. The fix allows the client to properly shutdown without getting stuck waiting for operations to complete.

  • Removes blocking receiveClose.await() and sendClose.await() calls from the shutdown process
  • Re-enables a previously disabled test case with updated transaction data
  • Updates various dependencies to newer versions

Reviewed Changes

Copilot reviewed 7 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/main/kotlin/io/newm/kogmios/ClientImpl.kt Removes blocking await calls during WebSocket closure to fix shutdown hang
src/test/kotlin/io/newm/kogmios/protocols/txsubmit/TxSubmitTest.kt Re-enables test case and updates transaction test data
buildSrc/src/main/kotlin/Versions.kt Updates dependency versions for various libraries
gradle/wrapper/gradle-wrapper.properties Updates Gradle version to 9.1.0
gradlew Updates Gradle wrapper script to use jar execution
gradlew.bat Updates Windows Gradle wrapper script to use jar execution
.github/workflows/ktlint.yml Updates ktlint version in CI workflow

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@AndrewWestberg AndrewWestberg force-pushed the STUD-499-newm-chain-hang-in-kogmios-shutdown branch from a9f9f5b to d5a03a6 Compare September 24, 2025 21:04
@AndrewWestberg AndrewWestberg force-pushed the STUD-499-newm-chain-hang-in-kogmios-shutdown branch from d5a03a6 to e280634 Compare September 24, 2025 21:06
@AndrewWestberg AndrewWestberg merged commit b7d7318 into master Sep 24, 2025
1 of 2 checks passed
@AndrewWestberg AndrewWestberg deleted the STUD-499-newm-chain-hang-in-kogmios-shutdown branch September 24, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants