Migrate from docker/build-push-action to stacker-build-push-action #499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
eusebiu-constantin-petu-dbk
force-pushed
the
test_stacker
branch
from
a08993e to
1dff8d1
Compare
Codecov Report
@@ Coverage Diff @@
## main #499 +/- ##
=======================================
Coverage 85.07% 85.07%
=======================================
Files 52 52
Lines 10682 10682
=======================================
Hits 9088 9088
Misses 1236 1236
Partials 358 358 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Contributor
|
This looks good, but where the "build-args" changes made to stacker-build-push-action? |
Collaborator
Author
I made a PR there and merged it, look there. |
Contributor
|
` Dockerfile Dockerfile-conformance Dockerfile-minimal Dockerfile-zb Dockerfile-zxp Why not the -conformance one? |
rchincha
force-pushed
the
test_stacker
branch
2 times, most recently
from
df36d1b to
42c29d7
Compare
eusebiu-constantin-petu-dbk
force-pushed
the
test_stacker
branch
15 times, most recently
from
b731673 to
bf46990
Compare
Signed-off-by: Petu Eusebiu <[email protected]>
eusebiu-constantin-petu-dbk
force-pushed
the
test_stacker
branch
4 times, most recently
from
5ccacbe to
2961499
Compare
eusebiu-constantin-petu-dbk
force-pushed
the
test_stacker
branch
2 times, most recently
from
f3e24fe to
85e0762
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Petu Eusebiu [email protected]
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.