Skip to content

device mount permission check in webhook #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 57 commits into
base: main
Choose a base branch
from
Open

device mount permission check in webhook #753

wants to merge 57 commits into from

Conversation

bindsi
Copy link
Member

@bindsi bindsi commented Apr 16, 2025 •
edited
Loading

What this PR does / why we need it:
Add akri-udev dependency and implement udev discovery validation for device mount permissions #738

If applicable:

  • this PR has an associated PR with documentation in akri-docs
  • this PR contains unit tests
  • added code adheres to standard Rust formatting (cargo fmt)
  • code builds properly (cargo build)
  • code is free of common mistakes (cargo clippy)
  • all Akri tests succeed (cargo test)
  • inline documentation builds (cargo doc)
  • all commits pass the DCO bot check by being signed off -- see the failing DCO check for instructions on how to retroactively sign commits

bindsi and others added 30 commits January 17, 2025 17:17
@bindsi
added configuring of device mount permissions in udev discovery handler
2cce410 
project-akri#726

Signed-off-by: Marcel Bindseil <[email protected]>
@bindsi
incremented version
22793c1 
Signed-off-by: Marcel Bindseil <[email protected]>
@bindsi
formatting
202a64c 
Signed-off-by: Marcel Bindseil <[email protected]>
@bindsi
fixed version
e128934 
Signed-off-by: Marcel Bindseil <[email protected]>
@bindsi
updated helm chart version
bd46a44 
Signed-off-by: Marcel Bindseil <[email protected]>
@bindsi
updated rust version
382d3b9 
Signed-off-by: Marcel Bindseil <[email protected]>
@bindsi
updated rust version to 1.84
8802c88 
Signed-off-by: Marcel Bindseil <[email protected]>
@bindsi
fixed default for permissions
802f4b1 
Signed-off-by: Marcel Bindseil <[email protected]>
@bindsi
added default func for permissions
9ebea3c 
Signed-off-by: Marcel Bindseil <[email protected]>
@bindsi
updated rust version to 1.81
1939fbb 
Signed-off-by: Marcel Bindseil <[email protected]>
@bindsi @kate-goldenring
Update discovery-handlers/udev/src/discovery_handler.rs
7639e83 
Co-authored-by: Kate Goldenring <[email protected]>
Signed-off-by: Marcel Bindseil <[email protected]>
@bindsi
added unit test and added dependencies
dcfe306 
Signed-off-by: Marcel Bindseil <[email protected]>
@bindsi
test for permissions
e8ffe39 
Signed-off-by: Marcel Bindseil <[email protected]>
@bindsi
removed unused var
462d649 
Signed-off-by: Marcel Bindseil <[email protected]>
@bindsi
restructured test
c14d2fe 
Signed-off-by: Marcel Bindseil <[email protected]>
@bindsi
fixed test
be86a9c 
Signed-off-by: Marcel Bindseil <[email protected]>
@bindsi
added default permissions for lint files
0eb45b7 
Signed-off-by: Marcel Bindseil <[email protected]>
@bindsi
signoff Signed-off-by: Marcel Bindseil <[email protected]>
444c209 
Signed-off-by: Marcel Bindseil <[email protected]>
@bindsi
removed panic
b2540f4 
Signed-off-by: Marcel Bindseil <[email protected]>
@bindsi
Merge branch 'project-akri:main' into main
3bb1029
@bindsi
Merge branch 'project-akri:main' into main
e314f09
@bindsi
Add akri-udev dependency and implement udev discovery validation for …
31efd15 
…device mount permissions project-akri#738

Signed-off-by: Marcel Bindseil <[email protected]>
@bindsi
Merge branch 'project-akri:main' into main
998e7e7
@bindsi
Merge branch 'main' into feature/webhookcheck
e22be26
@bindsi
Bump version to 0.13.11 in Cargo.lock, Cargo.toml, and version.txt
5ba64f4 
Signed-off-by: Marcel Bindseil <[email protected]>
@bindsi
updated helm chart version
8a4ac71 
Signed-off-by: Marcel Bindseil <[email protected]>
@bindsi
Fix return type of validate_udev_discovery_details function to includ…
a246433 
…e error handling

Signed-off-by: Marcel Bindseil <[email protected]>
@bindsi
Refactor validate_udev_discovery_details function to improve error ha…
3df361f 
…ndling and parsing logic

Signed-off-by: Marcel Bindseil <[email protected]>
@bindsi
Return AdmissionResponse on error in validate_configuration function
8f141bd 
Signed-off-by: Marcel Bindseil <[email protected]>
@bindsi
formatting
4038e08 
Signed-off-by: Marcel Bindseil <[email protected]>
bindsi added 17 commits May 21, 2025 10:38
@bindsi
Update udevDevNullConfiguration.yaml to include permissions for udev …
0cd011e 
…rules

Signed-off-by: Marcel Bindseil <[email protected]>
@bindsi
no dependency
7de2148 
Signed-off-by: Marcel Bindseil <[email protected]>
@bindsi
added stage to build artifacts
86b58f0 
Signed-off-by: Marcel Bindseil <[email protected]>
@bindsi
Refactor udev configuration files to use consistent YAML syntax for r…
f9878b4 
…ules and permissions

Signed-off-by: Marcel Bindseil <[email protected]>
@bindsi
Refactor udev configuration files to use JSON format for discoveryDet…
a7de150 
…ails

Signed-off-by: Marcel Bindseil <[email protected]>
@bindsi
Fix JSON formatting in udevGroupedConfiguration.yaml for discoveryDet…
fc3d0f5 
…ails

Signed-off-by: Marcel Bindseil <[email protected]>
@bindsi
Uncomment docker save commands for agent and controller in run-test-c…
0840b5e 
…ases.yml

Signed-off-by: Marcel Bindseil <[email protected]>
@bindsi
Uncomment and enable artifact uploads for DebugEcho, UDEV, ONVIF, and…
095a1ce 
… OPCUA discovery containers in run-test-cases.yml

Signed-off-by: Marcel Bindseil <[email protected]>
@bindsi
Uncomment docker save commands for DebugEcho, UDEV, ONVIF, and OPCUA …
2e11475 
…discovery containers in run-test-cases.yml

Signed-off-by: Marcel Bindseil <[email protected]>
@bindsi
Update udev discoveryDetails to use ENV variable for ID_PATH
9ada4e5 
Signed-off-by: Marcel Bindseil <[email protected]>
@bindsi
Add debug print statement for discoveryDetails path in grouped_config
5d8435b 
Signed-off-by: Marcel Bindseil <[email protected]>
@bindsi
Remove groupRecursive from udev discoveryDetails in udevGroupedConfig…
fa0f9f4 
…uration.yaml

Signed-off-by: Marcel Bindseil <[email protected]>
@bindsi
Restore groupRecursive and format udevRules in discoveryDetails for u…
5c1d686 
…dev configuration

Signed-off-by: Marcel Bindseil <[email protected]>
@bindsi
Refactor udevGroupedConfiguration to remove groupRecursive and update…
d6566c3 
… discoveryDetails format

Signed-off-by: Marcel Bindseil <[email protected]>
@bindsi
Update discoveryDetails format in udevGroupedConfiguration for consis…
e35716e 
…tency

Signed-off-by: Marcel Bindseil <[email protected]>
@bindsi
Add debug print statement for discoveryDetails path in grouped_config
da07fe4 
Signed-off-by: Marcel Bindseil <[email protected]>
@bindsi
Add groupRecursive to discoveryDetails in udevGroupedConfiguration
64a3572 
Signed-off-by: Marcel Bindseil <[email protected]>
@bindsi bindsi requested a review from kate-goldenring May 22, 2025 06:11
@bindsi bindsi marked this pull request as ready for review May 22, 2025 06:12
bindsi added 2 commits May 22, 2025 14:38
@bindsi
Remove debug print statements from grouped_config fixture in test_udev
21dff76 
Signed-off-by: Marcel Bindseil <[email protected]>
@bindsi
Bump version to 0.13.12 in Cargo.lock, Cargo.toml, Chart.yaml, and ve…
38ec820 
…rsion.txt; update test configuration for udev validation

Signed-off-by: Marcel Bindseil <[email protected]>
@yujinkim-msft yujinkim-msft added version/patch Patch version change is needed and removed same version version/patch Patch version change is needed labels Jun 18, 2025
@yujinkim-msft
Copy link
Collaborator

/version patch

@github-actions github-actions bot added the version/patch Patch version change is needed label Jun 18, 2025
github-actions bot and others added 2 commits June 18, 2025 18:04
@github-actions
Update patch version
15a4bcb 
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@yujinkim-msft
Merge branch 'main' into feature/webhookcheck
08c1e54
@yujinkim-msft yujinkim-msft added same version and removed version/patch Patch version change is needed labels Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kate-goldenring kate-goldenring Awaiting requested review from kate-goldenring

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
same version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bindsi @yujinkim-msft