Replaced redundant else if statement with else statement #8016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amante' Woodley <[email protected]> Co-authored-by: Nia Perez <[email protected]> Co-authored-by: Kayla Bobo <[email protected]> Co-authored-by: Silas Morgan <[email protected]>
|
🎉 Thanks for opening this pull request! For guidance on contributing, check out our contributor guidelines and other resources for contributors! Thank You! |
awood0727
force-pushed
the
loopOptimization
branch
from
1725148 to
ad887d3
Compare
perminder-17
approved these changes
Aug 2, 2025
perminder-17
reviewed
Aug 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6660
Changes:
In this pull request, my team, which includes @npNSU, @kaybcodes, @SilasVM, and I made a change to line 495, which addressed the error of JavaScript being only able to check for references and not values. I changed the else if statement to an else statement and deleted the conditions. Hopefully, this is not too similar to PR#6662, and it also makes the program run more efficiently by removing a redundant check.
Hey @limzykenneth and @davepagurek, we noticed you two have been working diligently to find a pull request that can resolve the issue. We saw a comment about breaking early. If you have any advice on that, we may be able to implement it. Please let us know what you think. Thank you both for all that you have done.
Screenshots of the change:
PR Checklist
npm run lintpasses