Skip to content

Replace fn with direct downloadFile import to fix issue where fn was not found #7971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

acgillette
Copy link

Resolves #7905

Changes:
Change the p5.Geometry file to import downloadFile directly and call it rather than relying on fn, which was returning undefined. Also updated the stlSave function and tested that it worked.

Wasn't sure if the fn in the geometry function was needed so left it. Also wasn't sure if unit tests should be added, so I left as is for the moment.

PR Checklist

Copy link

welcome bot commented Jul 15, 2025

🎉 Thanks for opening this pull request! For guidance on contributing, check out our contributor guidelines and other resources for contributors!
🤔 Please ensure that your PR links to an issue, which has been approved for work by a maintainer; otherwise, there might already be someone working on it, or still ongoing discussion about implementation. You are welcome to join the discussion in an Issue if you're not sure!
🌸 Once your PR is merged, be sure to add yourself to the list of contributors on the readme page !

Thank You!

Copy link
Contributor

@davepagurek davepagurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for taking this on!

@davepagurek davepagurek merged commit b858de8 into processing:dev-2.0 Jul 27, 2025
2 checks passed
@davepagurek
Copy link
Contributor

@all-contributors please add @acgillette for code

Copy link
Contributor

@davepagurek

I've put up a pull request to add @acgillette! 🎉

@acgillette acgillette deleted the saveObj_failing_download_fix branch July 30, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants