Fix inline anonymous functions causing a parsing error in p5.strands callbacks #7956
Conversation
|
🎉 Thanks for opening this pull request! For guidance on contributing, check out our contributor guidelines and other resources for contributors! Thank You! |
| @@ -19,7 +19,7 @@ function shadergenerator(p5, fn) { | |||
| if (shaderModifier instanceof Function) { | |||
| let generatorFunction; | |||
| if (options.parser) { | |||
| const sourceString = shaderModifier.toString() | |||
| const sourceString = `(${shaderModifier.toString()})`; | |||
There was a problem hiding this comment.
Do you mind adding a comment here to explain to other contributors why the brackets are necessary?
There was a problem hiding this comment.
Would something like this work?
// #7955 Wrap function declaration code in brackets so anonymous functions are not top level statements, which causes an error in acorn when parsing
There was a problem hiding this comment.
Nice! I will be able to make a commit later today
|
@all-contributors please add @nking07049925 for code |
|
I've put up a pull request to add @nking07049925! 🎉 |
Resolves #7955
Changes:
WebGL
ShaderGenerator.jsUnit Tests
p5.Shaderfor an anonymous function being passed into the shaderScreenshots of the change
Example from the issue running locally with no errors
PR Checklist
npm run lintpasses