-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Update fullstack examples with prisma config and pg adapter #8344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: prisma-7
Are you sure you want to change the base?
Update fullstack examples with prisma config and pg adapter #8344
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughMigrates multiple ORM example projects from Prisma Accelerate extension to Prisma Postgres adapter (PrismaPg), updates Prisma versions to 6.19.0, introduces explicit Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs
Pre-merge checks❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
orm/nuxt/README.md (1)
208-226: Remove stale Accelerate removal instructions.This section still tells readers to uninstall
@prisma/extension-accelerateand dropwithAccelerate(), but the example now ships with@prisma/adapter-pg. Following these outdated steps won’t help anyone switching databases off Postgres—they actually need guidance on removing or replacing the adapter-based client setup. Please update this block to reflect the new adapter workflow so the migration instructions remain correct.orm/nextjs/README.md (1)
200-281: Add guidance on removing the Postgres adapter when changing databases.The new setup initializes
PrismaClientwith@prisma/adapter-pg, yet this section now says you can target SQLite/MySQL/etc. by only changing the datasource connection. If readers keep the Postgres adapter in place, those drivers won’t work and the example fails. Please update these database-switch instructions to explain how to drop (or replace) the adapter when moving away from Postgres so the steps are actually runnable.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (26)
.github/get-ppg-dev/index.js(1 hunks)orm/betterauth-nextjs/package.json(1 hunks)orm/betterauth-nextjs/prisma.config.ts(1 hunks)orm/betterauth-nextjs/prisma/schema.prisma(0 hunks)orm/betterauth-nextjs/src/lib/prisma.ts(1 hunks)orm/nextjs/README.md(3 hunks)orm/nextjs/lib/prisma.ts(1 hunks)orm/nextjs/package.json(1 hunks)orm/nextjs/prisma.config.ts(1 hunks)orm/nextjs/prisma/schema.prisma(0 hunks)orm/nuxt-prisma-module/README.md(2 hunks)orm/nuxt-prisma-module/lib/prisma.ts(1 hunks)orm/nuxt-prisma-module/package.json(1 hunks)orm/nuxt-prisma-module/prisma.config.ts(1 hunks)orm/nuxt/README.md(2 hunks)orm/nuxt/package.json(1 hunks)orm/nuxt/prisma.config.ts(1 hunks)orm/nuxt/prisma/db.ts(1 hunks)orm/react-router-7/app/lib/prisma.ts(1 hunks)orm/react-router-7/package.json(2 hunks)orm/react-router-7/prisma.config.ts(1 hunks)orm/react-router-7/prisma/schema.prisma(0 hunks)orm/solid-start/lib/prisma.ts(1 hunks)orm/solid-start/package.json(2 hunks)orm/solid-start/prisma.config.ts(1 hunks)orm/solid-start/prisma/schema.prisma(0 hunks)
💤 Files with no reviewable changes (4)
- orm/solid-start/prisma/schema.prisma
- orm/betterauth-nextjs/prisma/schema.prisma
- orm/react-router-7/prisma/schema.prisma
- orm/nextjs/prisma/schema.prisma
🧰 Additional context used
🧠 Learnings (9)
📓 Common learnings
Learnt from: aidankmcalister
Repo: prisma/prisma-examples PR: 8334
File: orm/fastify-graphql-sdl-first/src/context.ts:1-1
Timestamp: 2025-10-27T13:18:46.546Z
Learning: The prisma/prisma-examples repository is a monorepo containing many independent example projects. When reviewing PRs in this repository, focus only on the files actually changed by the author in that specific PR, not on other example projects or infrastructure that wasn't modified.
Learnt from: aidankmcalister
Repo: prisma/prisma-examples PR: 8334
File: orm/betterauth-astro/src/pages/sign-up/index.astro:20-36
Timestamp: 2025-10-24T17:50:48.569Z
Learning: Do not suggest code changes or improvements to code in Prisma example repositories (prisma/prisma-examples). These examples are carefully set up and intentionally aligned with external documentation and information.
Learnt from: FGoessler
Repo: prisma/prisma-examples PR: 8260
File: generator-prisma-client/nextjs-starter-webpack-turborepo/packages/database/package.json:13-13
Timestamp: 2025-08-22T12:12:24.602Z
Learning: When analyzing changes from package.json seed scripts to "prisma db seed", always verify the actual content of prisma.config.ts rather than relying solely on regex patterns, as the configuration may be properly defined but in a format that doesn't match overly restrictive search patterns.
📚 Learning: 2025-08-22T12:12:24.602Z
Learnt from: FGoessler
Repo: prisma/prisma-examples PR: 8260
File: generator-prisma-client/nextjs-starter-webpack-turborepo/packages/database/package.json:13-13
Timestamp: 2025-08-22T12:12:24.602Z
Learning: When analyzing changes from package.json seed scripts to "prisma db seed", always verify the actual content of prisma.config.ts rather than relying solely on regex patterns, as the configuration may be properly defined but in a format that doesn't match overly restrictive search patterns.
Applied to files:
orm/react-router-7/package.jsonorm/betterauth-nextjs/package.jsonorm/solid-start/prisma.config.tsorm/betterauth-nextjs/prisma.config.tsorm/nuxt/prisma/db.tsorm/nextjs/package.json.github/get-ppg-dev/index.jsorm/nuxt-prisma-module/package.jsonorm/nuxt/prisma.config.tsorm/betterauth-nextjs/src/lib/prisma.tsorm/nuxt-prisma-module/prisma.config.tsorm/nuxt-prisma-module/lib/prisma.tsorm/nextjs/prisma.config.tsorm/react-router-7/prisma.config.tsorm/nuxt/package.jsonorm/nuxt/README.mdorm/solid-start/package.jsonorm/react-router-7/app/lib/prisma.tsorm/nextjs/README.mdorm/nextjs/lib/prisma.tsorm/solid-start/lib/prisma.tsorm/nuxt-prisma-module/README.md
📚 Learning: 2025-10-15T13:58:59.096Z
Learnt from: AmanVarshney01
Repo: prisma/prisma-examples PR: 8327
File: orm/graphql-auth/prisma/schema.prisma:2-4
Timestamp: 2025-10-15T13:58:59.096Z
Learning: The "prisma-client" generator provider (introduced in Prisma v6) is the newer, ESM-ready alternative to "prisma-client-js". It requires an explicit output path and is better suited for modern runtimes, edge deployments, and will become the default in Prisma v7. Use "prisma-client" for new projects or when modernizing existing projects.
Applied to files:
orm/react-router-7/package.jsonorm/solid-start/prisma.config.tsorm/betterauth-nextjs/prisma.config.tsorm/nuxt/prisma/db.tsorm/nextjs/package.jsonorm/nuxt-prisma-module/package.jsonorm/nuxt/prisma.config.tsorm/betterauth-nextjs/src/lib/prisma.tsorm/nuxt-prisma-module/prisma.config.tsorm/nuxt-prisma-module/lib/prisma.tsorm/nextjs/prisma.config.tsorm/react-router-7/prisma.config.tsorm/nuxt/package.jsonorm/nuxt/README.mdorm/solid-start/package.jsonorm/react-router-7/app/lib/prisma.tsorm/nextjs/README.mdorm/nextjs/lib/prisma.tsorm/solid-start/lib/prisma.tsorm/nuxt-prisma-module/README.md
📚 Learning: 2025-10-15T13:58:29.130Z
Learnt from: AmanVarshney01
Repo: prisma/prisma-examples PR: 8327
File: orm/fastify-graphql/prisma/schema.prisma:2-4
Timestamp: 2025-10-15T13:58:29.130Z
Learning: In Prisma v6.15 and later, `provider = "prisma-client"` is a valid generator configuration value when combined with `engineType = "client"`. This configuration generates a Prisma client without Rust engine binaries, relying on JavaScript driver adapters instead, and is different from the traditional `provider = "prisma-client-js"` configuration.
Applied to files:
orm/solid-start/prisma.config.tsorm/betterauth-nextjs/prisma.config.tsorm/nuxt/prisma/db.tsorm/nuxt/prisma.config.tsorm/betterauth-nextjs/src/lib/prisma.tsorm/nuxt-prisma-module/prisma.config.tsorm/nuxt-prisma-module/lib/prisma.tsorm/nextjs/prisma.config.tsorm/react-router-7/prisma.config.tsorm/nuxt/README.mdorm/react-router-7/app/lib/prisma.tsorm/nextjs/README.mdorm/nextjs/lib/prisma.tsorm/solid-start/lib/prisma.tsorm/nuxt-prisma-module/README.md
📚 Learning: 2025-10-15T13:56:01.807Z
Learnt from: AmanVarshney01
Repo: prisma/prisma-examples PR: 8327
File: orm/graphql-subscriptions/prisma/schema.prisma:1-5
Timestamp: 2025-10-15T13:56:01.807Z
Learning: In Prisma v6.15 and later, `engineType = "client"` is a valid generator configuration value that generates a Prisma client without Rust engine binaries, relying on JavaScript driver adapters instead (e.g., prisma/adapter-pg). This is useful for edge and serverless deployments.
Applied to files:
orm/nuxt/prisma/db.tsorm/betterauth-nextjs/src/lib/prisma.tsorm/nuxt-prisma-module/lib/prisma.tsorm/nuxt/README.mdorm/react-router-7/app/lib/prisma.tsorm/nextjs/README.mdorm/nextjs/lib/prisma.tsorm/solid-start/lib/prisma.tsorm/nuxt-prisma-module/README.md
📚 Learning: 2025-08-22T12:12:43.161Z
Learnt from: FGoessler
Repo: prisma/prisma-examples PR: 8260
File: generator-prisma-client/nextjs-starter-turbopack/components/quotes.tsx:1-1
Timestamp: 2025-08-22T12:12:43.161Z
Learning: In Next.js applications using Prisma, the connection() function from 'next/server' serves a different purpose than 'export const dynamic = force-dynamic'. The connection() function ensures proper database connection context and request isolation, while dynamic = 'force-dynamic' only controls rendering strategy. Both should be used together and are not redundant.
Applied to files:
orm/nuxt/prisma/db.ts.github/get-ppg-dev/index.jsorm/betterauth-nextjs/src/lib/prisma.tsorm/nuxt-prisma-module/lib/prisma.tsorm/react-router-7/app/lib/prisma.tsorm/nextjs/README.mdorm/nextjs/lib/prisma.tsorm/solid-start/lib/prisma.tsorm/nuxt-prisma-module/README.md
📚 Learning: 2025-10-27T13:18:46.546Z
Learnt from: aidankmcalister
Repo: prisma/prisma-examples PR: 8334
File: orm/fastify-graphql-sdl-first/src/context.ts:1-1
Timestamp: 2025-10-27T13:18:46.546Z
Learning: In the prisma/prisma-examples repository, generated Prisma client files (typically at paths like `prisma/generated/client`) are intentionally not committed to the repository. These files are generated at build/test time. Do not flag missing generated client artifacts as issues in reviews.
Applied to files:
orm/react-router-7/prisma.config.tsorm/nuxt/README.mdorm/nextjs/README.mdorm/nuxt-prisma-module/README.md
📚 Learning: 2025-10-27T13:18:46.546Z
Learnt from: aidankmcalister
Repo: prisma/prisma-examples PR: 8334
File: orm/fastify-graphql-sdl-first/src/context.ts:1-1
Timestamp: 2025-10-27T13:18:46.546Z
Learning: The prisma/prisma-examples repository is a monorepo containing many independent example projects. When reviewing PRs in this repository, focus only on the files actually changed by the author in that specific PR, not on other example projects or infrastructure that wasn't modified.
Applied to files:
orm/react-router-7/prisma.config.tsorm/nuxt/README.mdorm/nuxt-prisma-module/README.md
📚 Learning: 2025-10-24T17:50:48.569Z
Learnt from: aidankmcalister
Repo: prisma/prisma-examples PR: 8334
File: orm/betterauth-astro/src/pages/sign-up/index.astro:20-36
Timestamp: 2025-10-24T17:50:48.569Z
Learning: Do not suggest code changes or improvements to code in Prisma example repositories (prisma/prisma-examples). These examples are carefully set up and intentionally aligned with external documentation and information.
Applied to files:
orm/nuxt/README.mdorm/nextjs/README.mdorm/nuxt-prisma-module/README.md
🧬 Code graph analysis (4)
orm/betterauth-nextjs/src/lib/prisma.ts (1)
orm/nuxt/prisma/db.ts (1)
prisma(16-16)
orm/react-router-7/app/lib/prisma.ts (1)
orm/nuxt/prisma/db.ts (1)
prisma(16-16)
orm/nextjs/lib/prisma.ts (4)
orm/nuxt/prisma/db.ts (1)
prisma(16-16)orm/graphql/src/db.ts (1)
prisma(4-4)orm/prisma-mocking-javascript/client.js (1)
prisma(3-3)orm/testing-express/src/app.ts (1)
prisma(5-5)
orm/solid-start/lib/prisma.ts (1)
orm/nuxt/prisma/db.ts (1)
prisma(16-16)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (33)
- GitHub Check: test (orm/betterauth-nextjs)
- GitHub Check: test (orm/ai-sdk-nextjs)
- GitHub Check: test (orm/graphql)
- GitHub Check: test (orm/betterauth-astro)
- GitHub Check: test (orm/astro)
- GitHub Check: test (orm/authjs-nextjs)
- GitHub Check: test (orm/clerk-nextjs)
- GitHub Check: test (orm/fastify-graphql)
- GitHub Check: test (orm/fastify)
- GitHub Check: test (orm/fastify-graphql-sdl-first)
- GitHub Check: test (orm/express)
- GitHub Check: test (orm/graphql-nexus)
- GitHub Check: test (orm/graphql-auth)
- GitHub Check: test (orm/graphql-subscriptions)
- GitHub Check: test (orm/graphql-sdl-first)
- GitHub Check: test (orm/grpc)
- GitHub Check: test (orm/hapi-graphql-sdl-first)
- GitHub Check: test (orm/hapi-graphql)
- GitHub Check: test (orm/hapi)
- GitHub Check: test (orm/nest)
- GitHub Check: test (orm/hono)
- GitHub Check: test (orm/nest-graphql)
- GitHub Check: test (orm/nextjs)
- GitHub Check: test (orm/koa)
- GitHub Check: test (orm/nextjs-graphql)
- GitHub Check: test (orm/nest-graphql-sdl-first)
- GitHub Check: test (orm/nextjs-trpc)
- GitHub Check: test (orm/nuxt)
- GitHub Check: test (orm/script)
- GitHub Check: test (orm/sveltekit)
- GitHub Check: test (orm/solid-start)
- GitHub Check: test (orm/react-router-7)
- GitHub Check: test (orm/testing-express)
🔇 Additional comments (12)
orm/nuxt/prisma/db.ts (3)
2-2: LGTM!Correct import for the PostgreSQL adapter migration.
6-7: LGTM! Correct migration to adapter-based pattern.The migration from Prisma Accelerate extension to the PostgreSQL adapter is correctly implemented. The pool is properly initialized with the database connection string and passed to PrismaClient.
1-1: Update comment URL to reference Nuxt or generic Prisma best practices.The comment references Next.js-specific documentation, but this is a Nuxt example. This inconsistency could confuse users.
Consider updating to a Nuxt-specific or framework-agnostic Prisma guide.
⛔ Skipped due to learnings
Learnt from: FGoessler Repo: prisma/prisma-examples PR: 8260 File: generator-prisma-client/nextjs-starter-webpack-turborepo/packages/database/package.json:13-13 Timestamp: 2025-08-22T12:12:24.602Z Learning: When analyzing changes from package.json seed scripts to "prisma db seed", always verify the actual content of prisma.config.ts rather than relying solely on regex patterns, as the configuration may be properly defined but in a format that doesn't match overly restrictive search patterns.Learnt from: aidankmcalister Repo: prisma/prisma-examples PR: 8334 File: orm/betterauth-astro/src/pages/sign-up/index.astro:20-36 Timestamp: 2025-10-24T17:50:48.569Z Learning: Do not suggest code changes or improvements to code in Prisma example repositories (prisma/prisma-examples). These examples are carefully set up and intentionally aligned with external documentation and information.Learnt from: aidankmcalister Repo: prisma/prisma-examples PR: 8334 File: orm/fastify-graphql-sdl-first/src/context.ts:1-1 Timestamp: 2025-10-27T13:18:46.546Z Learning: In the prisma/prisma-examples repository, generated Prisma client files (typically at paths like `prisma/generated/client`) are intentionally not committed to the repository. These files are generated at build/test time. Do not flag missing generated client artifacts as issues in reviews.Learnt from: FGoessler Repo: prisma/prisma-examples PR: 8260 File: generator-prisma-client/nextjs-starter-turbopack/components/quotes.tsx:1-1 Timestamp: 2025-08-22T12:12:43.161Z Learning: In Next.js applications using Prisma, the connection() function from 'next/server' serves a different purpose than 'export const dynamic = force-dynamic'. The connection() function ensures proper database connection context and request isolation, while dynamic = 'force-dynamic' only controls rendering strategy. Both should be used together and are not redundant.Learnt from: AmanVarshney01 Repo: prisma/prisma-examples PR: 8327 File: orm/graphql-auth/prisma/schema.prisma:2-4 Timestamp: 2025-10-15T13:58:59.096Z Learning: The "prisma-client" generator provider (introduced in Prisma v6) is the newer, ESM-ready alternative to "prisma-client-js". It requires an explicit output path and is better suited for modern runtimes, edge deployments, and will become the default in Prisma v7. Use "prisma-client" for new projects or when modernizing existing projects..github/get-ppg-dev/index.js (1)
15-15: Verify the property exists and add defensive error handling.The property path change from
server.ppg.urltoserver.database.prismaORMConnectionStringis part of the adapter migration and is integrated into the CI test pipeline. However:
- Since
unstable_startServeris an undocumented unstable API, the exact object structure is not publicly documented and could change without notice- The downstream CI script in
.github/tests/databases/prisma-postgres/run.shwaits for output matching^prisma+postgres://and fails with a timeout if this pattern isn't found within 60 seconds- If
server.database.prismaORMConnectionStringis undefined, the console output will be "undefined", causing the test to failBefore merging, verify:
- The tests actually pass with the current
@prisma/devversion- Consider adding defensive checks (e.g.,
console.log(server.database?.prismaORMConnectionString || '')) to catch potential undefined values and provide clearer error messagesorm/nuxt-prisma-module/README.md (1)
45-45: Documentation accurately reflects the adapter-pg migration.The README correctly updates the DATABASE_URL format from Prisma Accelerate to a standard PostgreSQL connection string and documents the new
@prisma/adapter-pgusage pattern with clear code examples.Also applies to: 70-78
orm/react-router-7/prisma.config.ts (1)
1-13: Clean Prisma configuration setup.The configuration correctly uses
defineConfigwith appropriate paths, the classic engine, and environment-based datasource URL. The dotenv import ensures environment variables are loaded before configuration is processed.orm/solid-start/lib/prisma.ts (1)
1-7: Proper migration to PrismaPg adapter.The implementation correctly replaces the extension-based approach with the adapter pool pattern. The
PrismaPgpool is initialized with the connection string and passed toPrismaClientvia theadapteroption, maintaining the same export interface.orm/betterauth-nextjs/prisma.config.ts (1)
1-13: Configuration correctly structured.The Prisma configuration properly defines all required fields with appropriate paths and the classic engine. The dotenv import ensures DATABASE_URL is available during configuration.
orm/solid-start/prisma.config.ts (1)
1-14: Configuration includes seed script definition.The configuration correctly includes the seed script within the migrations block (line 8), eliminating the need for a separate package.json seed script entry. All other fields are properly configured.
orm/react-router-7/app/lib/prisma.ts (1)
1-11: Adapter migration with proper singleton pattern.The migration to
PrismaPgadapter is correctly implemented, and the global singleton pattern for development (lines 7-9) ensures proper connection reuse during hot module replacement.orm/betterauth-nextjs/src/lib/prisma.ts (1)
1-11: Clean adapter integration with development safeguards.The
PrismaPgadapter implementation is correct, and the development-mode singleton pattern (lines 7-9) prevents connection pool exhaustion during hot reloads.orm/react-router-7/package.json (1)
13-13: Dependencies correctly updated for adapter-pg migration.The package correctly replaces
@prisma/extension-acceleratewith@prisma/adapter-pg(line 13) and addsdotenvas a devDependency (line 27) to support environment variable loading in the new configuration pattern.Also applies to: 27-27
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
.github/get-ppg-dev/index.js(1 hunks).github/tests/orm/betterauth-nextjs/run.sh(2 hunks).github/tests/orm/nextjs/run.sh(2 hunks).github/tests/orm/nuxt/run.sh(2 hunks).github/tests/orm/react-router-7/run.sh(2 hunks).github/tests/orm/solid-start/run.sh(2 hunks)
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: aidankmcalister
Repo: prisma/prisma-examples PR: 8334
File: orm/fastify-graphql-sdl-first/src/context.ts:1-1
Timestamp: 2025-10-27T13:18:46.546Z
Learning: The prisma/prisma-examples repository is a monorepo containing many independent example projects. When reviewing PRs in this repository, focus only on the files actually changed by the author in that specific PR, not on other example projects or infrastructure that wasn't modified.
Learnt from: aidankmcalister
Repo: prisma/prisma-examples PR: 8334
File: orm/betterauth-astro/src/pages/sign-up/index.astro:20-36
Timestamp: 2025-10-24T17:50:48.569Z
Learning: Do not suggest code changes or improvements to code in Prisma example repositories (prisma/prisma-examples). These examples are carefully set up and intentionally aligned with external documentation and information.
Learnt from: FGoessler
Repo: prisma/prisma-examples PR: 8260
File: generator-prisma-client/nextjs-starter-webpack-turborepo/packages/database/package.json:13-13
Timestamp: 2025-08-22T12:12:24.602Z
Learning: When analyzing changes from package.json seed scripts to "prisma db seed", always verify the actual content of prisma.config.ts rather than relying solely on regex patterns, as the configuration may be properly defined but in a format that doesn't match overly restrictive search patterns.
📚 Learning: 2025-08-22T12:12:24.602Z
Learnt from: FGoessler
Repo: prisma/prisma-examples PR: 8260
File: generator-prisma-client/nextjs-starter-webpack-turborepo/packages/database/package.json:13-13
Timestamp: 2025-08-22T12:12:24.602Z
Learning: When analyzing changes from package.json seed scripts to "prisma db seed", always verify the actual content of prisma.config.ts rather than relying solely on regex patterns, as the configuration may be properly defined but in a format that doesn't match overly restrictive search patterns.
Applied to files:
.github/tests/orm/betterauth-nextjs/run.sh.github/tests/orm/nextjs/run.sh.github/tests/orm/nuxt/run.sh.github/tests/orm/react-router-7/run.sh.github/tests/orm/solid-start/run.sh.github/get-ppg-dev/index.js
📚 Learning: 2025-08-22T12:12:43.161Z
Learnt from: FGoessler
Repo: prisma/prisma-examples PR: 8260
File: generator-prisma-client/nextjs-starter-turbopack/components/quotes.tsx:1-1
Timestamp: 2025-08-22T12:12:43.161Z
Learning: In Next.js applications using Prisma, the connection() function from 'next/server' serves a different purpose than 'export const dynamic = force-dynamic'. The connection() function ensures proper database connection context and request isolation, while dynamic = 'force-dynamic' only controls rendering strategy. Both should be used together and are not redundant.
Applied to files:
.github/get-ppg-dev/index.js
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (31)
- GitHub Check: test (orm/astro)
- GitHub Check: test (orm/betterauth-nextjs)
- GitHub Check: test (orm/clerk-nextjs)
- GitHub Check: test (orm/betterauth-astro)
- GitHub Check: test (orm/express)
- GitHub Check: test (orm/ai-sdk-nextjs)
- GitHub Check: test (orm/fastify-graphql-sdl-first)
- GitHub Check: test (orm/hono)
- GitHub Check: test (orm/grpc)
- GitHub Check: test (orm/fastify)
- GitHub Check: test (orm/authjs-nextjs)
- GitHub Check: test (orm/hapi-graphql)
- GitHub Check: test (orm/graphql-auth)
- GitHub Check: test (orm/graphql-subscriptions)
- GitHub Check: test (orm/graphql-sdl-first)
- GitHub Check: test (orm/hapi)
- GitHub Check: test (orm/fastify-graphql)
- GitHub Check: test (orm/graphql)
- GitHub Check: test (orm/koa)
- GitHub Check: test (orm/graphql-nexus)
- GitHub Check: test (orm/nest)
- GitHub Check: test (orm/hapi-graphql-sdl-first)
- GitHub Check: test (orm/nest-graphql-sdl-first)
- GitHub Check: test (orm/nest-graphql)
- GitHub Check: test (orm/nuxt)
- GitHub Check: test (orm/nextjs-graphql)
- GitHub Check: test (orm/nextjs-trpc)
- GitHub Check: test (orm/nextjs)
- GitHub Check: test (orm/react-router-7)
- GitHub Check: test (orm/solid-start)
- GitHub Check: test (orm/sveltekit)
🔇 Additional comments (5)
.github/tests/orm/solid-start/run.sh (1)
38-49: LGTM! Pattern updated correctly for standard PostgreSQL URLs.The grep pattern change from
^prisma+postgres://to^postgres://correctly aligns with the new adapter-pg workflow where standard PostgreSQL connection strings are emitted..github/tests/orm/betterauth-nextjs/run.sh (1)
38-49: LGTM! Consistent pattern update.The changes correctly update the log parsing to match standard PostgreSQL URLs, consistent with the adapter-pg migration.
.github/tests/orm/react-router-7/run.sh (1)
38-49: LGTM! Test updated for adapter-pg workflow.The grep pattern correctly matches the standard PostgreSQL URLs now emitted by the dev server.
.github/tests/orm/nuxt/run.sh (1)
38-49: LGTM! Correctly updated for PostgreSQL URL format.The changes align with the broader migration to adapter-pg across the examples.
.github/tests/orm/nextjs/run.sh (1)
38-49: LGTM! Final test script consistently updated.All test scripts now correctly parse the standard PostgreSQL connection string format, completing the migration to adapter-pg.
9d673ab to
04b85a5
Compare
e69531c
59ba4de to
e69531c
Compare
Summary by CodeRabbit