Skip to content

Conversation

HDinger
Copy link
Contributor

@HDinger HDinger commented May 12, 2025

What are you trying to accomplish?

Provide a default id for the clear button wihtin TextFields if clear_button_id is empty

Integration

I don't think so..

List the issues that this change affects.

Closes #3482

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

I used SecureRandom.uuid to provide a randomized ID. The generate_id method is only available in the scope of Primer::Component but not in Primer::Forms::Dsl

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

@HDinger HDinger requested a review from a team as a code owner May 12, 2025 07:09
@HDinger HDinger requested a review from TylerJDev May 12, 2025 07:09
Copy link

changeset-bot bot commented May 12, 2025

🦋 Changeset detected

Latest commit: be4ebed

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jonrohan jonrohan added the skip changeset Pull requests that don't change the library output label May 14, 2025
@jonrohan jonrohan enabled auto-merge May 14, 2025 17:28
@jonrohan jonrohan added this pull request to the merge queue May 14, 2025
Merged via the queue into primer:main with commit 1165454 May 14, 2025
31 of 34 checks passed
@primer primer bot mentioned this pull request May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset Pull requests that don't change the library output
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CloseButton in TextFiels is missing a default ID
2 participants