-
Notifications
You must be signed in to change notification settings - Fork 621
[SelectPanel] Announce loading prop changes #6404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SelectPanel] Announce loading prop changes #6404
Conversation
🦋 Changeset detectedLatest commit: 56779a3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds accessibility improvements to the SelectPanel component by implementing loading state announcements when loading is managed externally via props. The change ensures screen reader users are informed when content is loading, with a delay mechanism to avoid unnecessary announcements for quick operations.
- Adds a new useEffect hook to handle loading announcements when
loadingManagedExternally
is true - Implements delayed announcement logic to prevent announcing loading for quick operations
- Provides proper cleanup of loading announcements when loading completes
size-limit report 📦
|
Closes https://github.com/github/primer/issues/4978
Changelog
This pull request introduces a new
useEffect
hook in theSelectPanel
component to manage loading announcements when loading is managed via props.The change also ensures a smooth user experience by delaying announcements for quick-loading scenarios.
New
Added logic to handle announcements when the loading prop changes
Changed
Removed
Rollout strategy
Testing & Reviewing
Merge checklist