Skip to content

Adjust ActionList label font-weight if a list has both items with descriptions AND without #6262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Jul 23, 2025

Conversation

langermank
Copy link
Contributor

@langermank langermank commented Jul 1, 2025

Closes https://github.com/github/primer/issues/2884

If a list contains a mix of items with and without descriptions, we'll remove the bold from the label to create better continuity between items. This is a bit of an edge case that has come up several times across gh/gh.

Changelog

New

  • Adds some CSS to detect if a list has a mix of descriptions with no descriptions

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Jul 1, 2025

🦋 Changeset detected

Latest commit: 4c1afd9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jul 1, 2025
Copy link
Contributor

github-actions bot commented Jul 1, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copy link
Contributor

github-actions bot commented Jul 1, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 92.33 KB (+0.1% 🔺)
packages/react/dist/browser.umd.js 92.47 KB (+0.13% 🔺)

@github-actions github-actions bot requested a deployment to storybook-preview-6262 July 2, 2025 18:40 Abandoned
@github-actions github-actions bot requested a deployment to storybook-preview-6262 July 2, 2025 18:51 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-6262 July 2, 2025 19:04 Inactive
@github-actions github-actions bot requested a deployment to storybook-preview-6262 July 23, 2025 17:01 Abandoned
@langermank langermank added this pull request to the merge queue Jul 23, 2025
Merged via the queue into main with commit 82e9237 Jul 23, 2025
43 checks passed
@langermank langermank deleted the al-desc-label-bold branch July 23, 2025 19:19
@primer primer bot mentioned this pull request Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants