Skip to content

chore(ActionList): Remove the CSS modules feature flag from the ActionList.Divider component #6022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 9, 2025
Merged

chore(ActionList): Remove the CSS modules feature flag from the ActionList.Divider component #6022

merged 2 commits into from
May 9, 2025

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented May 7, 2025

Closes https://github.com/github/primer/issues/5169

Changelog

New

Changed

Removed

Remove the CSS modules feature flag from the ActionList.Divider component

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 7, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: db9e315

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels May 7, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2025 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 98.46 KB (-0.08% 🔽)
packages/react/dist/browser.umd.js 98.83 KB (-0.01% 🔽)

@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/376835

@github-actions github-actions bot temporarily deployed to storybook-preview-6022 May 7, 2025 21:13 Inactive
@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels May 7, 2025
@jonrohan jonrohan marked this pull request as ready for review May 7, 2025 21:46
@Copilot Copilot AI review requested due to automatic review settings May 7, 2025 21:47
@jonrohan jonrohan requested a review from a team as a code owner May 7, 2025 21:47
@jonrohan jonrohan requested a review from joshblack May 7, 2025 21:47
@jonrohan jonrohan enabled auto-merge May 7, 2025 21:47
Copilot
Copilot AI reviewed May 7, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the legacy CSS modules feature flag logic from the ActionList.Divider component so that it always uses the CSS modules–based styling, and updates snapshots and the changeset accordingly.

  • Always render the divider via BoxWithFallback with the CSS modules class
  • Remove feature flag imports and branches for CSS modules vs. sx styling
  • Update NavList snapshots to include the "Divider" class and bump the minor version

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
packages/react/src/NavList/snapshots/NavList.test.tsx.snap Updated snapshots to reflect the added “Divider” class on <li> elements
packages/react/src/ActionList/Divider.tsx Removed feature-flag branches and now always renders divider via BoxWithFallback with CSS modules
.changeset/curvy-lions-buy.md Added a changeset for a minor version bump

packages/react/src/ActionList/Divider.tsx
return (
<Box
<BoxWithFallback
Copy link
Preview

Copilot AI May 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sx prop is destructured but never passed to BoxWithFallback, so any custom styling via sx will be ignored (and sx will trigger an unused-variable warning). Please forward sx={sx} to BoxWithFallback or remove it from the component signature.

Copilot uses AI. Check for mistakes.

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label May 9, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2025

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@jonrohan jonrohan added this pull request to the merge queue May 9, 2025
Merged via the queue into main with commit 1f53127 May 9, 2025
33 of 34 checks passed
@jonrohan jonrohan deleted the css_modules_remove_flag/actionlist_divider branch May 9, 2025 15:39
@primer primer bot mentioned this pull request May 9, 2025
Merged
jonrohan added a commit that referenced this pull request May 9, 2025
@jonrohan @primer
chore(ActionList): Remove the CSS modules feature flag from the Actio…
6213a04 
…nList.Divider component (#6022)

Co-authored-by: primer[bot] <119360173+primer[bot]@users.noreply.github.com>
jonrohan added a commit that referenced this pull request May 9, 2025
@jonrohan @primer
chore(ActionList): Remove the CSS modules feature flag from the Actio…
776de1b 
…nList.Divider component (#6022)

Co-authored-by: primer[bot] <119360173+primer[bot]@users.noreply.github.com>
hectahertz pushed a commit that referenced this pull request May 20, 2025
@jonrohan @primer @hectahertz
chore(ActionList): Remove the CSS modules feature flag from the Actio…
53a1140 
…nList.Divider component (#6022)

Co-authored-by: primer[bot] <119360173+primer[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@joshblack joshblack joshblack approved these changes

Assignees
No one assigned
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonrohan @joshblack