Skip to content

Fix(Dialog): set height limit of 35% to DialogHeader #5996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 5, 2025

Conversation

francinelucca
Copy link
Member

@francinelucca francinelucca commented May 2, 2025

Closes #

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented May 2, 2025

🦋 Changeset detected

Latest commit: dd55000

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels May 2, 2025
Copy link
Contributor

github-actions bot commented May 2, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copy link
Contributor

github-actions bot commented May 2, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 98.94 KB (0%)
packages/react/dist/browser.umd.js 99.08 KB (0%)

@github-actions github-actions bot requested a deployment to storybook-preview-5996 May 2, 2025 20:09 Abandoned
@francinelucca francinelucca marked this pull request as ready for review May 2, 2025 20:18
@Copilot Copilot AI review requested due to automatic review settings May 2, 2025 20:18
@francinelucca francinelucca requested a review from a team as a code owner May 2, 2025 20:18
@francinelucca francinelucca requested a review from jonrohan May 2, 2025 20:18
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a maximum height constraint to the dialog header so that it does not exceed 35% of the viewport height.

  • Adds max-height: 35vh to .Header in Dialog.module.css
  • Introduces a changeset for a patch release

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/react/src/Dialog/Dialog.module.css Enforces a max-height on the .Header
.changeset/tame-pumpkins-jump.md Records the patch release for this change
Comments suppressed due to low confidence (2)

packages/react/src/Dialog/Dialog.module.css:217

  • [nitpick] Consider adding a Storybook example or unit test that demonstrates and verifies header overflow behavior under the new max-height constraint.
max-height: 35vh;

packages/react/src/Dialog/Dialog.module.css:217

  • The PR title/description refers to "35%" but the code uses 35vh. If the intent was to limit to 35% of the container, consider using 35% instead of 35vh, or update the description to reflect viewport units.
max-height: 35vh;

@github-actions github-actions bot temporarily deployed to storybook-preview-5996 May 2, 2025 20:24 Inactive
@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels May 2, 2025
Copy link
Contributor

github-actions bot commented May 2, 2025

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot added integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels May 2, 2025
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label May 2, 2025
Copy link
Contributor

github-actions bot commented May 2, 2025

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/376114

@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh labels May 2, 2025
@github-actions github-actions bot requested a deployment to storybook-preview-5996 May 2, 2025 23:16 Abandoned
@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels May 2, 2025
@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@francinelucca francinelucca added this pull request to the merge queue May 5, 2025
Merged via the queue into main with commit 49fa2c8 May 5, 2025
45 checks passed
@francinelucca francinelucca deleted the fix/set-limit-to-dialog-header branch May 5, 2025 21:50
@primer primer bot mentioned this pull request May 5, 2025
hectahertz pushed a commit that referenced this pull request May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants