-
Notifications
You must be signed in to change notification settings - Fork 622
Fix(Dialog): set height limit of 35% to DialogHeader #5996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: dd55000 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a maximum height constraint to the dialog header so that it does not exceed 35% of the viewport height.
- Adds
max-height: 35vh
to.Header
inDialog.module.css
- Introduces a changeset for a patch release
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
packages/react/src/Dialog/Dialog.module.css | Enforces a max-height on the .Header |
.changeset/tame-pumpkins-jump.md | Records the patch release for this change |
Comments suppressed due to low confidence (2)
packages/react/src/Dialog/Dialog.module.css:217
- [nitpick] Consider adding a Storybook example or unit test that demonstrates and verifies header overflow behavior under the new max-height constraint.
max-height: 35vh;
packages/react/src/Dialog/Dialog.module.css:217
- The PR title/description refers to "35%" but the code uses
35vh
. If the intent was to limit to 35% of the container, consider using35%
instead of35vh
, or update the description to reflect viewport units.
max-height: 35vh;
Co-authored-by: Copilot <[email protected]>
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/376114 |
🟢 golden-jobs completed with status |
Co-authored-by: Copilot <[email protected]>
Closes #
Changelog
New
Changed
Removed
Rollout strategy
Testing & Reviewing
Merge checklist