-
Notifications
You must be signed in to change notification settings - Fork 622
chore(Popover): Remove the CSS modules feature flag for the Popover component #5827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 03f25b6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/376662 |
🟢 golden-jobs completed with status |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the legacy CSS modules feature flag from the Popover component and standardizes on the new toggleSxComponent
approach for both Popover
and Popover.Content
.
- Drop
styled-components
anduseFeatureFlag
–based toggling logic - Introduce
toggleSxComponent
for Popover wrapper and content - Update the changeset to reflect a minor version bump
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
File | Description |
---|---|
packages/react/src/Popover/Popover.tsx | Removed CSS modules flag and styled-components code; added toggleSxComponent usage |
.changeset/green-carpets-float.md | Added changeset entry for the minor bump removing the CSS modules flag |
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
Closes https://github.com/github/primer/issues/4505
Closes https://github.com/github/primer/issues/4139
Changelog
New
Changed
Removed
Rollout strategy
Testing & Reviewing
Merge checklist