Skip to content

chore(NavList) add e2e tests #5432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 13, 2024
Merged

chore(NavList) add e2e tests #5432

merged 4 commits into from
Dec 13, 2024

Conversation

langermank
Copy link
Contributor

@langermank langermank commented Dec 13, 2024 •
edited
Loading

  • Add e2e snapshots for NavList
  • Fix markup bug causes a11y failures

Adding snapshots caused an accessibility failure due to some incompatible markup. I added a new prop to try and address that. There are cases where this heading should be a div (I think most cases?) but within NavList it should sometimes be an li.

before after
image image

@langermank langermank requested a review from a team as a code owner December 13, 2024 00:19
@langermank langermank requested a review from TylerJDev December 13, 2024 00:19
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 13, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 7f1e7af

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@langermank langermank added skip changeset This change does not need a changelog update snapshots labels Dec 13, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5432 December 13, 2024 00:21 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 13, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 103.23 KB (+0.03% 🔺)
packages/react/dist/browser.umd.js 103.57 KB (+0.02% 🔺)

@primer primer bot requested a review from a team as a code owner December 13, 2024 00:30
@primer primer bot requested a review from maximedegreve December 13, 2024 00:30
@primer primer bot temporarily deployed to github-pages December 13, 2024 00:31 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5432 December 13, 2024 00:32 Inactive
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@langermank langermank requested review from mperrotti and removed request for maximedegreve December 13, 2024 15:31
@github-actions github-actions bot temporarily deployed to storybook-preview-5432 December 13, 2024 15:33 Inactive
@github-actions GitHub Actions
Copy link
Contributor

Uh oh! @langermank, the image you shared is missing helpful alt text. Check your pull request body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/355064

@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Dec 13, 2024
@langermank langermank requested a review from jonrohan December 13, 2024 16:05
TylerJDev
TylerJDev approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@TylerJDev TylerJDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✨

@langermank langermank removed the skip changeset This change does not need a changelog label Dec 13, 2024
@langermank langermank added this pull request to the merge queue Dec 13, 2024
Merged via the queue into main with commit 60a2f47 Dec 13, 2024
43 checks passed
@langermank langermank deleted the navlist-e2e branch December 13, 2024 16:24
@primer primer bot mentioned this pull request Dec 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerJDev TylerJDev TylerJDev approved these changes

@mperrotti mperrotti Awaiting requested review from mperrotti

@jonrohan jonrohan Awaiting requested review from jonrohan

Assignees
No one assigned
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@langermank @TylerJDev