Heading tests, testing cleanup #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, why isn't this branch being built by Travis? 🤔 |
We don't have private repositories turned on for travis-ci 🤑 |
|
We do, though! https://travis-ci.com/primer/primer-react |
|
Ahhhh:
|
|
Anyway, how about a review? 😊 |
Merged
shawnbot
commented
May 31, 2018
src/Heading.js
Outdated
| Heading.h3.defaultProps = {m: 0, fontSize: 3} | ||
| Heading.h4.defaultProps = {m: 0, fontSize: 2} | ||
| Heading.h5.defaultProps = {m: 0, fontSize: 1} | ||
| Heading.h6.defaultProps = {m: 0, fontSize: 0} |
There was a problem hiding this comment.
TODO: don't tie font size to heading level. We want people to be more intentional about how they use headings.
There was a problem hiding this comment.
We want this:
<Heading tag='h1' fontSize={6} />
jonrohan
approved these changes
May 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heading.h{1-6}and updates the examples to use the<Heading tag='h{1-6}'>form.render()function defined in each of our component test files.Note that if we change the
defaultPropsfor any of our headings now, we'll probably need to update the tests. The tests are also a bit brittle in that rendered classnames are expected to be in a specific order. We need to decide whether this is important and update the equality tests accordingly (for instance, using a Set to compare equality instead of an array).