Don't export new high contrast modes #1245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasoppermann
added
the
skip changeset
|
There was a problem hiding this comment.
Pull Request Overview
This PR implements selective Figma export functionality for color themes by adding an exportToFigma flag to each theme configuration. The change prevents high-contrast accessibility variants from being exported to Figma while maintaining their availability for other build processes.
- Added
exportToFigmaboolean property to all theme configurations - Modified the Figma build script to filter themes based on the new flag
- Set high-contrast themes to
exportToFigma: falseand all other themes totrue
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| scripts/themes.config.ts | Added exportToFigma property to all theme configurations, setting high-contrast variants to false |
| scripts/buildFigma.ts | Updated to filter themes based on the new exportToFigma flag before processing |
| import {figma} from '../src/platforms/index.js' | ||
| import type {ConfigGeneratorOptions} from '../src/types/styleDictionaryConfigGenerator.js' | ||
| import {getFallbackTheme} from './utilities/getFallbackTheme.js' | ||
|
|
||
| const buildFigma = async (buildOptions: ConfigGeneratorOptions): Promise<void> => { | ||
| const themes = origialThemes.filter(theme => theme.exportToFigma !== false) |
There was a problem hiding this comment.
There's a typo in the variable name. 'origialThemes' should be 'originalThemes'.
Suggested change
| const themes = origialThemes.filter(theme => theme.exportToFigma !== false) | |
| import {themes as originalThemes} from './themes.config.js' | |
| import {figma} from '../src/platforms/index.js' | |
| import type {ConfigGeneratorOptions} from '../src/types/styleDictionaryConfigGenerator.js' | |
| import {getFallbackTheme} from './utilities/getFallbackTheme.js' | |
| const buildFigma = async (buildOptions: ConfigGeneratorOptions): Promise<void> => { | |
| const themes = originalThemes.filter(theme => theme.exportToFigma !== false) |
Copilot uses AI. Check for mistakes.
Design Token Diff (Figma)
|
langermank
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR make sure that we only export indented color themes for Figma.