Skip to content

Update control knob border-color values #1239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 23, 2025
Merged

Update control knob border-color values #1239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3cf9c98
use default border for control knob
langermank Jul 16, 2025
870e182
Update `control` knob border-color values to minor...
langermank Jul 16, 2025
0250069
github-actions[bot] Regenerated snapshots
langermank Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/spicy-goats-rush.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/primitives": minor
---

Update `control` knob border-color values
Binary file modified ...book-all-color-swatches-light-colorblind-controlKnob-borderColor-rest-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...shots/storybook-all-color-swatches-light-controlKnob-borderColor-rest-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...book-all-color-swatches-light-tritanopia-controlKnob-borderColor-rest-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
11 changes: 9 additions & 2 deletions src/tokens/functional/color/control.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1283,7 +1283,7 @@
},
borderColor: {
rest: {
$value: '{control.borderColor.emphasis}',
$value: '{control.borderColor.rest}',
$type: 'color',
$extensions: {
'org.primer.figma': {
Expand All @@ -1292,7 +1292,14 @@
scopes: ['borderColor'],
},
'org.primer.overrides': {
dark: '{control.borderColor.emphasis}',
dark: '{control.borderColor.rest}',
'dark-dimmed-high-contrast': '{control.borderColor.emphasis}',
'light-high-contrast': '{control.borderColor.emphasis}',
'light-tritanopia-high-contrast': '{control.borderColor.emphasis}',
'light-protanopia-deuteranopia-high-contrast': '{control.borderColor.emphasis}',
'dark-high-contrast': '{control.borderColor.emphasis}',
'dark-tritanopia-high-contrast': '{control.borderColor.emphasis}',
'dark-protanopia-deuteranopia-high-contrast': '{control.borderColor.emphasis}',
Comment on lines +1296 to +1302
Copy link
Preview

Copilot AI Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The high contrast theme overrides could be organized alphabetically for better maintainability. Consider grouping light themes first, then dark themes, and within each group sort alphabetically.

Suggested change
'dark-dimmed-high-contrast': '{control.borderColor.emphasis}',
'light-high-contrast': '{control.borderColor.emphasis}',
'light-tritanopia-high-contrast': '{control.borderColor.emphasis}',
'light-protanopia-deuteranopia-high-contrast': '{control.borderColor.emphasis}',
'dark-high-contrast': '{control.borderColor.emphasis}',
'dark-tritanopia-high-contrast': '{control.borderColor.emphasis}',
'dark-protanopia-deuteranopia-high-contrast': '{control.borderColor.emphasis}',
'light-high-contrast': '{control.borderColor.emphasis}',
'light-protanopia-deuteranopia-high-contrast': '{control.borderColor.emphasis}',
'light-tritanopia-high-contrast': '{control.borderColor.emphasis}',
'dark-dimmed-high-contrast': '{control.borderColor.emphasis}',
'dark-high-contrast': '{control.borderColor.emphasis}',
'dark-protanopia-deuteranopia-high-contrast': '{control.borderColor.emphasis}',
'dark-tritanopia-high-contrast': '{control.borderColor.emphasis}',

Copilot uses AI. Check for mistakes.

},
},
},
Expand Down