Skip to content

[DEVEX-2380]: Update group reference in catalog-info.yaml #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 28, 2025
Merged

[DEVEX-2380]: Update group reference in catalog-info.yaml #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c53d3e6
fix owner
cpiemontese Jan 20, 2025
55ba7c7
try fixing rust version
cpiemontese Jan 20, 2025
5e827f6
try override command
cpiemontese Jan 22, 2025
042fbc4
add missing components for lint
cpiemontese Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- run: |
rustup override set 1.76.0
rustup component add rustfmt
rustup component add clippy
rustup component add rust-docs
Comment on lines +15 to +19
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need the override?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the action by itself installs the latest version of rust

- uses: Swatinem/rust-cache@v2
- uses: taiki-e/install-action@cargo-make
- uses: taiki-e/install-action@cargo-deny
Expand All @@ -36,6 +41,7 @@ jobs:
steps:
- run: sudo echo "127.0.0.1 jaeger" | sudo tee -a /etc/hosts
- uses: actions/checkout@v4
- run: rustup override set 1.76.0
- uses: Swatinem/rust-cache@v2
- uses: taiki-e/install-action@cargo-make
- uses: taiki-e/install-action@nextest
Expand Down
2 changes: 1 addition & 1 deletion .mise.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
[tools]
rust = "1.76"
rust = "1.76.0"
2 changes: 1 addition & 1 deletion catalog-info.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ kind: Component
spec:
type: library
lifecycle: production
owner: team-shared-services
owner: team-developer-experience
system: prima.it
metadata:
name: prima_tracing.rs
Expand Down
Loading