-
-
Notifications
You must be signed in to change notification settings - Fork 265
docs: mention allowTemplateLiterals: "never"
for @stylistic/quotes
rule
#344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
WalkthroughThe README documentation was updated to clarify the configuration of the ESLint Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
🔇 Additional comments (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to 79d32c0 in 1 minute and 16 seconds. Click for details.
- Reviewed
13
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. README.md:619
- Draft comment:
The note clarifies that @stylistic/quotes now expects "never" instead of false. Consider updating the example configuration to use "never" for consistency. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_g1dSIPBG153LSxPB
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
@stylistic/quotes
deprecated Boolean value for this option.https://eslint.style/rules/quotes#options
Important
Update
README.md
to clarifyallowTemplateLiterals
option for@stylistic/quotes
rule, using"never"
instead offalse
.README.md
to specify that@stylistic/quotes
uses"never"
instead offalse
forallowTemplateLiterals
option.This description was created by
for 79d32c0. You can customize this summary. It will automatically update as commits are pushed.
Summary by CodeRabbit
quotes
rule to disallow unnecessary backticks, including a note on option value differences between ESLint core and the@stylistic/quotes
plugin.