Add support to thrift serde with pooled bytebuffer #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shangm2
commented
Aug 18, 2025
shangm2
commented
- Add support to tBinaryProtocol to write from or read to a list of pooled byte buffers
6 tasks
arhimondr
reviewed
Aug 28, 2025
|
|
||
| public void release(ByteBuffer byteBuffer) | ||
| { | ||
| byteBuffer.clear(); |
There was a problem hiding this comment.
nit: maybe check if the buffer is of expected size
| this.bufferSize = bufferSize; | ||
| pool = new ArrayBlockingQueue<>(maxCount); | ||
|
|
||
| // Pre-populate the pool |
There was a problem hiding this comment.
nit: Is probably okay to populate lazily
| private final ArrayBlockingQueue<ByteBuffer> pool; | ||
| private final int bufferSize; | ||
|
|
||
| private static final AtomicInteger idGenerator = new AtomicInteger(); |
| @@ -210,6 +213,21 @@ public void writeBinary(ByteBuffer value) | |||
| transport.write(value.array(), value.position() + value.arrayOffset(), length); | |||
| } | |||
|
|
|||
| @Override | |||
| public void writeBinaryFromBuffers(List<ByteBuffer> byteBuffers) | |||
There was a problem hiding this comment.
nit: maybe simply writeBinary
| return Collections.emptyList(); | ||
| } | ||
|
|
||
| List<ByteBuffer> byteBuffers = new ArrayList<>(); |
There was a problem hiding this comment.
nit: prefer ImutableList (e.g.: ImmutableList.builder())
| default void writeBinaryFromBuffers(List<ByteBuffer> byteBuffers) | ||
| throws TException | ||
| { | ||
| throw new UnsupportedOperationException("writeBinaryFromBuffers is not supported"); |
| import java.nio.ByteBuffer; | ||
| import java.util.List; | ||
|
|
||
| public class ByteBufferInputStream |
There was a problem hiding this comment.
Please cover it with a unit test well. Or consider ByteSource from Guava (e.g.: ByteSource#concat)
| private final List<ByteBuffer> byteBuffers; | ||
| private ByteBuffer currentBuffer; | ||
|
|
||
| public ByteBufferOutputStream(ByteBufferPool pool, List<ByteBuffer> byteBuffers) |
There was a problem hiding this comment.
Consider creating the List<ByteBuffer> byteBuffers here and returning it from a method (e.g.: List getBytes())
| private final List<ByteBuffer> byteBuffers; | ||
| private ByteBuffer currentBuffer; | ||
|
|
||
| public ByteBufferOutputStream(ByteBufferPool pool, List<ByteBuffer> byteBuffers) |
| } | ||
| } | ||
|
|
||
| public void finish() |
There was a problem hiding this comment.
e.g.: Return a List from here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.