-
-
Couldn't load subscription status.
- Fork 74
🌅 FigureResampler display improvements #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@jonasvdd this PR should only be merged if you are fine with adding the behavior described above (of course)! |
|
@jvdd, I like this behavior! |
|
I think this is somewhat related to the issues in #99, maybe we can improve the documentation about the dynamic aggregation as-well? |
|
Jup @jonasvdd, I think revisiting the documentation will never hurt, certainly with the many new PRs that recently have been merged! |
| show_mean_aggregation_size: bool = True, | ||
| convert_traces_kwargs: dict | None = None, | ||
| verbose: bool = False, | ||
| show_dash_kwargs: dict | None = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is no (generated) documentation for this arg as the documentation from the superclass its __init__ is used
This PR does;
FigureResamplerwhen height is not passed(this is because the default plotly figure height is 450, but the default jupyter-dash app height is 650 👉 👈 )
show_dash_kwargstoFigureResampleripython displayis called on aFigureResamplerit will start an inline jupyter-dash app_get_pr_props_keysThis PR adds the following behavior to
FigureResampler; when havingfigas output in your notebook (_ipython_display_) -> now a dash app will be started under the hood withmode = "inline"Users can control the port and other properties of the dash app via the
show_dash_kwargsthat is added to the constructor ofFigureResampler. This can be set in two manners;fig = FigureResampler(..., show_dash_kwargs=dict(port=8051))register_plotly_resampler(mode="figure", show_dash_kwargs=dict(port=8051))