Skip to content

Conversation

@jvdd
Copy link
Member

@jvdd jvdd commented Jun 18, 2023

Fixes #223

@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.11%. Comparing base (c905478) to head (78461a5).
Report is 58 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #228      +/-   ##
==========================================
+ Coverage   97.06%   97.11%   +0.04%     
==========================================
  Files          13       13              
  Lines         988     1005      +17     
==========================================
+ Hits          959      976      +17     
  Misses         29       29              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jvdd
Copy link
Member Author

jvdd commented Jun 18, 2023

@jonasvdd any reason why we had the reset layout (autorange & range) for x and y axes in the constructor?


If we have a legit reason to do this, we can toggle this behavior by adding a new constructor argument (e.g., reset_axes_range, which defaults to True)

@jonasvdd
Copy link
Member

jonasvdd commented Jul 3, 2023

I'm fine with commenting this out!

@jvdd jvdd marked this pull request as ready for review July 9, 2023 08:48
@jvdd jvdd merged commit 2125b66 into main Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't automatically add axis: {"autorange": True, "range": None} when converting existing figures

3 participants