-
-
Notifications
You must be signed in to change notification settings - Fork 4
Refine adapter guidelines #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
in A4, does it make sense to have as a requirement the option "no logging"? I would expect only "debug" and "release" to be required. |
The original motivation was that one might want to completely switch off the adapter-related information (only), since they consider the adapter only a small/technical part of the overall simulation. In that sense, it would make sense to not get additional log lines for every solver time step, for example. While this could already be covered by a This was originally suggested by @uekerman. This is now an additional requirement anyway. I will add a suggestion. |
Co-authored-by: Gerasimos Chourdakis <[email protected]>
Co-authored-by: Gerasimos Chourdakis <[email protected]>
Takes into account reviews of: