Skip to content

Conversation

MakisH
Copy link
Member

@MakisH MakisH commented Aug 30, 2025

  • Clarifies R.2 and A.11 for integrated adapters.
  • Clarifies in A.4 that logging level can be configurable at compile time.
  • Clarifies A.10 to make it easier to answer it.

Takes into account reviews of:

@MakisH MakisH requested a review from uekerman August 30, 2025 06:38
@MakisH MakisH self-assigned this Aug 30, 2025
@carme-hp
Copy link
Member

in A4, does it make sense to have as a requirement the option "no logging"? I would expect only "debug" and "release" to be required.

@MakisH
Copy link
Member Author

MakisH commented Sep 3, 2025

in A4, does it make sense to have as a requirement the option "no logging"? I would expect only "debug" and "release" to be required.

The original motivation was that one might want to completely switch off the adapter-related information (only), since they consider the adapter only a small/technical part of the overall simulation. In that sense, it would make sense to not get additional log lines for every solver time step, for example. While this could already be covered by a release level, a no logging could additionally disable any configuration/initialization info, for example.

This was originally suggested by @uekerman. This is now an additional requirement anyway. I will add a suggestion.

uekerman and others added 2 commits September 4, 2025 11:08
@MakisH MakisH merged commit 982d165 into main Sep 4, 2025
@MakisH MakisH deleted the refine-adapter-guidelines branch September 4, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants