chore: use v8 coverage #4807
Merged
chore: use v8 coverage #4807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Tachometer Benchmark ResultsSummaryA summary of the benchmark results will show here once they finish. ResultsThe full results of your benchmarks will show here once they finish. |
43081j
force-pushed
the
vitest-v8
branch
2 times, most recently
from
5a08e03 to
8107e15
Compare
This was referenced Jun 24, 2025
43081j
force-pushed
the
vitest-v8
branch
3 times, most recently
from
df08982 to
b470b28
Compare
JoviDeCroock
approved these changes
Jun 25, 2025
|
Thinking more about this, how does this work with coveralls? preact/.github/workflows/build-test.yml Line 39 in 7fbc10d I can see |
|
That's the same output before this change. If you look at another branch that doesn't include this, it is the same I think it just means there's no coverage errors, i.e thresholds were met When I'm at a laptop again I can have a look at the report it outputs to be sure it is right still |
Switches to using vitest's v8 coverage provider which should be faster and more accurate.
|
@JoviDeCroock you were right, it is fixed now 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches to using vitest's v8 coverage provider which should be faster
and more accurate.
Depends on #4806 and #4808