feat: Add command invoker types #4692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukewarlow
force-pushed
the
add-command-types
branch
from
d4daaac to
cb05c34
Compare
lukewarlow
commented
Feb 18, 2025
src/jsx.d.ts
Outdated
| @@ -1613,6 +1613,9 @@ export namespace JSXInternal { | |||
|
|
|||
| interface ButtonHTMLAttributes<T extends EventTarget = HTMLButtonElement> | |||
| extends HTMLAttributes<T> { | |||
| command?: Signalish<string | undefined>; | |||
| commandfor?: Signalist<string | undefined>; | |||
| commandFor?: Signalist<string | undefined>; | |||
There was a problem hiding this comment.
There's a .commandForElement property that you can set to an element, it would be good to support this in Preact but popoverTargetElement also doesn't seem to be handled so will omit that for now.
|
TODO: Add onCommand IDL event handler |
rschristian
reviewed
Feb 19, 2025
📊 Tachometer Benchmark ResultsSummaryA summary of the benchmark results will show here once they finish. ResultsThe full results of your benchmarks will show here once they finish. |
Fix typo Co-authored-by: Ryan Christian <[email protected]>
lukewarlow
force-pushed
the
add-command-types
branch
from
0ac897a to
de8d894
Compare
|
HTML spec got merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference:
See chrome Intent to ship
Leaving as Draft till the spec is merged / Chrome i2S is approved.