refactor: Switch to Object.is for hook args #4663

rschristian · 2025-02-13T12:31:38Z

Supercedes #3954

Thought of this earlier, the v11 list reminded me.

github-actions · 2025-02-13T12:32:06Z

📊 Tachometer Benchmark Results

Summary

duration

create10k: unsure 🔍 -1% - +0% (-7.24ms - +1.42ms)
^{preact-local vs preact-main}
filter-list: unsure 🔍 -1% - +1% (-0.15ms - +0.15ms)
^{preact-local vs preact-main}
hydrate1k: unsure 🔍 -1% - +1% (-0.91ms - +0.94ms)
^{preact-local vs preact-main}
many-updates: unsure 🔍 -2% - +0% (-0.34ms - +0.07ms)
^{preact-local vs preact-main}
replace1k: unsure 🔍 -1% - +1% (-0.66ms - +0.56ms)
^{preact-local vs preact-main}
text-update: unsure 🔍 -4% - +5% (-0.09ms - +0.10ms)
^{preact-local vs preact-main}
todo: unsure 🔍 -3% - +2% (-1.10ms - +0.56ms)
^{preact-local vs preact-main}
update10th1k: unsure 🔍 -3% - +4% (-0.84ms - +1.29ms)
^{preact-local vs preact-main}

usedJSHeapSize

create10k: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
^{preact-local vs preact-main}
filter-list: unsure 🔍 -2% - +2% (-0.03ms - +0.03ms)
^{preact-local vs preact-main}
hydrate1k: unsure 🔍 -5% - +5% (-0.47ms - +0.48ms)
^{preact-local vs preact-main}
many-updates: unsure 🔍 -0% - +0% (-0.02ms - +0.02ms)
^{preact-local vs preact-main}
replace1k: unsure 🔍 -0% - +1% (-0.00ms - +0.02ms)
^{preact-local vs preact-main}
text-update: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
^{preact-local vs preact-main}
todo: faster ✔ 0% - 2% (0.00ms - 0.03ms)
^{preact-local vs preact-main}
update10th1k: unsure 🔍 -1% - +1% (-0.04ms - +0.02ms)
^{preact-local vs preact-main}

Results

create10k

Browser: chrome-headless
Sample size: 50
Built by: CI #4370
Commit: ff0c695

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	939.29ms - 944.61ms	-	unsure 🔍 -1% - +0% -7.24ms - +1.42ms
preact-main	941.45ms - 948.28ms	unsure 🔍 -0% - +1% -1.42ms - +7.24ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	19.19ms - 19.20ms	-	unsure 🔍 -0% - +0% -0.01ms - +0.01ms
preact-main	19.19ms - 19.20ms	unsure 🔍 -0% - +0% -0.01ms - +0.01ms	-

filter-list

Browser: chrome-headless
Sample size: 50
Built by: CI #4370
Commit: ff0c695

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	16.52ms - 16.78ms	-	unsure 🔍 -1% - +1% -0.15ms - +0.15ms
preact-main	16.57ms - 16.73ms	unsure 🔍 -1% - +1% -0.15ms - +0.15ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.52ms - 1.56ms	-	unsure 🔍 -2% - +2% -0.03ms - +0.03ms
preact-main	1.52ms - 1.56ms	unsure 🔍 -2% - +2% -0.03ms - +0.03ms	-

hydrate1k

Browser: chrome-headless
Sample size: 60
Built by: CI #4370
Commit: ff0c695

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	73.22ms - 74.59ms	-	unsure 🔍 -1% - +1% -0.91ms - +0.94ms
preact-main	73.26ms - 74.52ms	unsure 🔍 -1% - +1% -0.94ms - +0.91ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	9.44ms - 10.08ms	-	unsure 🔍 -5% - +5% -0.47ms - +0.48ms
preact-main	9.41ms - 10.11ms	unsure 🔍 -5% - +5% -0.48ms - +0.47ms	-

many-updates

Browser: chrome-headless
Sample size: 50
Built by: CI #4370
Commit: ff0c695

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	16.16ms - 16.53ms	-	unsure 🔍 -2% - +0% -0.34ms - +0.07ms
preact-main	16.39ms - 16.57ms	unsure 🔍 -0% - +2% -0.07ms - +0.34ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	3.75ms - 3.77ms	-	unsure 🔍 -0% - +0% -0.02ms - +0.02ms
preact-main	3.75ms - 3.77ms	unsure 🔍 -0% - +0% -0.02ms - +0.02ms	-

replace1k

Browser: chrome-headless
Sample size: 100
Built by: CI #4370
Commit: ff0c695

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	64.95ms - 65.61ms	-	unsure 🔍 -1% - +1% -0.66ms - +0.56ms
preact-main	64.81ms - 65.84ms	unsure 🔍 -1% - +1% -0.56ms - +0.66ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	2.96ms - 2.98ms	-	unsure 🔍 -0% - +1% -0.00ms - +0.02ms
preact-main	2.96ms - 2.97ms	unsure 🔍 -1% - +0% -0.02ms - +0.00ms	-

run-warmup-0

Version	Avg time	vs preact-local	vs preact-main
preact-local	29.40ms - 29.94ms	-	unsure 🔍 -2% - +1% -0.57ms - +0.15ms
preact-main	29.63ms - 30.12ms	unsure 🔍 -1% - +2% -0.15ms - +0.57ms	-

run-warmup-1

Version	Avg time	vs preact-local	vs preact-main
preact-local	33.30ms - 34.09ms	-	unsure 🔍 -1% - +2% -0.34ms - +0.76ms
preact-main	33.09ms - 33.87ms	unsure 🔍 -2% - +1% -0.76ms - +0.34ms	-

run-warmup-2

Version	Avg time	vs preact-local	vs preact-main
preact-local	25.15ms - 25.49ms	-	unsure 🔍 -1% - +1% -0.33ms - +0.21ms
preact-main	25.18ms - 25.58ms	unsure 🔍 -1% - +1% -0.21ms - +0.33ms	-

run-warmup-3

Version	Avg time	vs preact-local	vs preact-main
preact-local	24.12ms - 25.22ms	-	unsure 🔍 -5% - +2% -1.16ms - +0.42ms
preact-main	24.48ms - 25.60ms	unsure 🔍 -2% - +5% -0.42ms - +1.16ms	-

run-warmup-4

Version	Avg time	vs preact-local	vs preact-main
preact-local	24.24ms - 25.42ms	-	unsure 🔍 -1% - +5% -0.30ms - +1.25ms
preact-main	23.85ms - 24.86ms	unsure 🔍 -5% - +1% -1.25ms - +0.30ms	-

run-final

Version	Avg time	vs preact-local	vs preact-main
preact-local	19.94ms - 20.32ms	-	unsure 🔍 -1% - +2% -0.11ms - +0.42ms
preact-main	19.79ms - 20.16ms	unsure 🔍 -2% - +1% -0.42ms - +0.11ms	-

text-update

Browser: chrome-headless
Sample size: 70
Built by: CI #4370
Commit: ff0c695

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	2.07ms - 2.20ms	-	unsure 🔍 -4% - +5% -0.09ms - +0.10ms
preact-main	2.06ms - 2.21ms	unsure 🔍 -5% - +4% -0.10ms - +0.09ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.11ms - 1.11ms	-	unsure 🔍 +0% - +0% +0.00ms - +0.00ms
preact-main	1.11ms - 1.11ms	unsure 🔍 -0% - -0% -0.00ms - -0.00ms	-

todo

Browser: chrome-headless
Sample size: 50
Built by: CI #4370
Commit: ff0c695

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	34.41ms - 35.59ms	-	unsure 🔍 -3% - +2% -1.10ms - +0.56ms
preact-main	34.69ms - 35.86ms	unsure 🔍 -2% - +3% -0.56ms - +1.10ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.21ms - 1.22ms	-	faster ✔ 0% - 2% 0.00ms - 0.03ms
preact-main	1.22ms - 1.24ms	slower ❌ 0% - 2% 0.00ms - 0.03ms	-

update10th1k

Browser: chrome-headless
Sample size: 50
Built by: CI #4370
Commit: ff0c695

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	32.32ms - 33.87ms	-	unsure 🔍 -3% - +4% -0.84ms - +1.29ms
preact-main	32.14ms - 33.60ms	unsure 🔍 -4% - +3% -1.29ms - +0.84ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	2.92ms - 2.95ms	-	unsure 🔍 -1% - +1% -0.04ms - +0.02ms
preact-main	2.93ms - 2.97ms	unsure 🔍 -1% - +1% -0.02ms - +0.04ms	-

_{tachometer-reporter-action v2 for CI}

github-actions · 2025-02-13T12:33:00Z

Size Change: +37 B (+0.06%)

Total Size: 60.4 kB

Filename	Size	Change
`hooks/dist/hooks.js`	1.55 kB	+13 B (+0.85%)
`hooks/dist/hooks.module.js`	1.58 kB	+13 B (+0.83%)
`hooks/dist/hooks.umd.js`	1.62 kB	+11 B (+0.68%)

ℹ️ View Unchanged

Filename	Size
`compat/dist/compat.js`	3.67 kB
`compat/dist/compat.module.js`	3.59 kB
`compat/dist/compat.umd.js`	3.73 kB
`debug/dist/debug.js`	3.87 kB
`debug/dist/debug.module.js`	3.87 kB
`debug/dist/debug.umd.js`	3.95 kB
`devtools/dist/devtools.js`	260 B
`devtools/dist/devtools.module.js`	274 B
`devtools/dist/devtools.umd.js`	346 B
`dist/preact.js`	4.56 kB
`dist/preact.min.js`	4.6 kB
`dist/preact.min.module.js`	4.59 kB
`dist/preact.min.umd.js`	4.63 kB
`dist/preact.module.js`	4.59 kB
`dist/preact.umd.js`	4.65 kB
`jsx-runtime/dist/jsxRuntime.js`	957 B
`jsx-runtime/dist/jsxRuntime.module.js`	926 B
`jsx-runtime/dist/jsxRuntime.umd.js`	1.03 kB
`test-utils/dist/testUtils.js`	473 B
`test-utils/dist/testUtils.module.js`	477 B
`test-utils/dist/testUtils.umd.js`	555 B

_{compressed-size-action}

hooks/src/index.js

rschristian · 2025-02-13T13:25:45Z

So coveralls is dying for different reasons now. Yippee

https://status.coveralls.io/

Co-authored-by: jayrobin <[email protected]>

* Remove unused imports * refactor: Switch to Object.is for hook args * refactor: Copy to `useReducer` & store `Object` accessor * test: Add tests for `useEffect` & `useState` w/ `NaN` Co-authored-by: jayrobin <[email protected]> --------- Co-authored-by: jdecroock <[email protected]> Co-authored-by: jayrobin <[email protected]>

JoviDeCroock reviewed Feb 13, 2025

View reviewed changes

hooks/src/index.js Outdated Show resolved Hide resolved

JoviDeCroock mentioned this pull request Feb 13, 2025

(major) - Tracking PR for v11 #4549

Merged

1 task

rschristian marked this pull request as ready for review February 13, 2025 13:31

JoviDeCroock force-pushed the v11-2 branch from c4ed4f4 to 593b951 Compare February 13, 2025 16:19

JoviDeCroock force-pushed the refactor/object-is branch from a4491f6 to d2a3759 Compare February 13, 2025 16:25

Remove unused imports

13014a5

JoviDeCroock force-pushed the refactor/object-is branch from d2a3759 to ff0c695 Compare February 13, 2025 16:28

rschristian and others added 3 commits February 13, 2025 17:28

refactor: Switch to Object.is for hook args

df02e1d

refactor: Copy to useReducer & store Object accessor

57156cd

test: Add tests for useEffect & useState w/ NaN

ff0c695

Co-authored-by: jayrobin <[email protected]>

JoviDeCroock approved these changes Feb 13, 2025

View reviewed changes

rschristian merged commit 5094a51 into v11-2 Feb 14, 2025
12 checks passed

rschristian deleted the refactor/object-is branch February 14, 2025 06:07

rschristian mentioned this pull request Mar 10, 2025

Object.is fn for dependency comparison #4726

Closed

JoviDeCroock mentioned this pull request Aug 19, 2025

v11.0.0-beta.0 #4893

Merged

Uh oh!

refactor: Switch to Object.is for hook args #4663

refactor: Switch to Object.is for hook args #4663

Uh oh!

Conversation

rschristian commented Feb 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Tachometer Benchmark Results

Summary

duration

usedJSHeapSize

Results

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

run-warmup-0

run-warmup-1

run-warmup-2

run-warmup-3

run-warmup-4

run-final

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

Uh oh!

github-actions bot commented Feb 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

rschristian commented Feb 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rschristian commented Feb 13, 2025 •

edited

Loading

github-actions bot commented Feb 13, 2025 •

edited

Loading

github-actions bot commented Feb 13, 2025 •

edited

Loading

rschristian commented Feb 13, 2025 •

edited

Loading