Skip to content

FreeCam: Hide Disable Movement on unsupported games #1123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 10, 2024
Merged

FreeCam: Hide Disable Movement on unsupported games #1123

merged 3 commits into from
Nov 10, 2024

Conversation

@illusion0001
Copy link
Contributor

@illusion0001 illusion0001 commented Sep 16, 2024 •
edited
Loading

technically it only exists in re8

REFramework/src/mods/FreeCam.cpp

Lines 110 to 118 in 84ad03d

#ifdef RE8
const auto player = m_props_manager->player;
if (player != nullptr && player->transform != nullptr && player->transform == transform) {
if (m_disable_movement->value() || m_was_disabled) {
player->shouldUpdate = !m_disable_movement->value();
m_was_disabled = !player->shouldUpdate;
}
}
#endif

praydog
praydog reviewed Sep 16, 2024
View reviewed changes
src/mods/FreeCam.cpp Outdated
m_lock_camera->draw("Lock Position");

#ifndef SF6
#if !defined(SF6) || !defined(RE8)
Copy link
Owner

@praydog praydog Sep 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It exists in RE2, RE3, and RE8.

Copy link
Contributor Author

@illusion0001 illusion0001 Sep 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

praydog
praydog requested changes Sep 16, 2024
View reviewed changes
Copy link
Owner

@praydog praydog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to include RE2, RE3.

@praydog praydog changed the title FreeCam: Hide Disable Movement on non RE8 FreeCam: Hide Disable Movement on unsupported games Nov 10, 2024
@praydog praydog merged commit 99d0dfb into praydog:master Nov 10, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@praydog praydog praydog requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@illusion0001 @praydog