page.html: fix invalid HTML5 #894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`<label><div>...` is invalid, so is `<button><div>...` It seems like it can be simplified using `aria-label` on the target, which avoids repetition.
`<i class="icon">` was popularized by font-awesome but is semantically questionable. Just use `<span>`, the css selectors don't care, they're all `.icon`.
pradyunsg
approved these changes
Aug 17, 2025
|
Thanks @haampie! ^.^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<label><div>...is invalid, so is<button><div>...It seems like it can be simplified using
aria-labelon the referenced<input>and the<buton>itself, which avoids repetition as a bonus.Use
<span class="icon">instead of<i class="icon">(the latter was popularized by font-awesome but is semantically questionable). The CSS just uses.iconanyways.