Skip to content

chore: bump deps for k8s 1.33 compatibility #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025

Conversation

mydoomfr
Copy link
Contributor

Update dependencies and tooling for k8s 1.33 compatibility

@mydoomfr mydoomfr requested a review from antrema June 30, 2025 06:18
@mydoomfr mydoomfr self-assigned this Jun 30, 2025
@mydoomfr mydoomfr changed the title bump deps for k8s 1.33 compatibility chore: bump deps for k8s 1.33 compatibility Jun 30, 2025
Copy link
Collaborator

@antrema antrema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both imports are indirects, ok for me

@@ -51,6 +51,8 @@ require (
go.uber.org/automaxprocs v1.6.0 // indirect
go.uber.org/multierr v1.11.0 // indirect
go.uber.org/zap v1.27.0 // indirect
go.yaml.in/yaml/v2 v2.4.2 // indirect
go.yaml.in/yaml/v3 v3.0.3 // indirect
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 2 different versions for go.yaml.in/yaml ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they come from different dependencies, some of which are still using v2

btw I just discovered the go mod why command:

go mod why go.yaml.in/yaml/v2
# go.yaml.in/yaml/v2
github.com/powerdns-operator/powerdns-operator/api/v1alpha1
k8s.io/apimachinery/pkg/apis/meta/v1
k8s.io/apimachinery/pkg/apis/meta/v1.test
sigs.k8s.io/yaml
go.yaml.in/yaml/v2

@mydoomfr mydoomfr merged commit e4a101a into powerdns-operator:main Jul 1, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants