-
-
Notifications
You must be signed in to change notification settings - Fork 54
docs: clarify gc behavior of setQueryData
#361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for funny-banoffee-0afb46 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
WalkthroughA documentation note was added to clarify that unused query data in the cache is garbage collected after a configurable period, with a default of five minutes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/cookbook/prefetching.md (1)
40-40
: Consider adding a pointer on how to overridegcTime
.
Readers may wonder where to change this value; a short note or link to the option (e.g.,useQueryCache({ gcTime: ... })
) would close the loop.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/cookbook/prefetching.md
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Redirect rules
- GitHub Check: Header rules
- GitHub Check: Pages changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why add it here. I don't think it matches the page. I don't know if there is a correct place to put this yet
At first glance, I agree this isn’t the right place, so feel free to close the PR |
Still thanks a lot for opening the pr |
Added a note about GC behavior in
setQueryData
. I'm not sure it's necessary, so feel free to close if it's not needed.Summary by CodeRabbit