Correct path resolution when to/from paths match #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you want to run post-css on the following arrangement:
`postcss app/app.css -o app/app.bundle.css`
Postcss-url will then save the copied assets to process.cwd(), which in this case is `.`. Not correct. It should copy the assets to `app/${assetsPath}`.
This fix makes it so the assets are correctly copied to the same folder (presumably inside of a `assetsPath`.
I'm not 100% sure what the intention of the original logic was, but it appeared to be guarding for when there was a missing `to` option. This will still preserve the original behavior when `to` is !existy and use process.cwd(). Apologies if this understanding is incorrect.
sergcen
approved these changes
Sep 19, 2019
|
🎉🙏TY! I can float off the git commit until you do the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you want to run post-css on the following arrangement:
postcss app/app.css -o app/app.bundle.cssPostcss-url will then save the copied assets to
process.cwd(), which in this case is.. Not correct. It should copy the assets to./app/${assetsPath}.This fix makes it so the assets are correctly copied to the same folder (presumably inside of a
assetsPath) when atooption exists. Otherwise, use the old cwd() behavior.I'm not 100% sure what the intention of the original logic was, but it appeared to be guarding for when there was a missing
tooption. This will still preserve the original behavior whentois !existy and use process.cwd(). Apologies if this understanding is incorrect.