-
Notifications
You must be signed in to change notification settings - Fork 10
Introduced new vars to control the usage of the env vars of the pod #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
matan84
wants to merge
8
commits into
main
Choose a base branch
from
add-option-to-remove-env-vars-access
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+742
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sInJQ as new vars to control the usage of the env vars
Code Coverage Artifact 📈: https://github.com/port-labs/port-k8s-exporter/actions/runs/18541687265/artifacts/4281558084Code Coverage Total Percentage:
|
Code Coverage Artifact 📈: https://github.com/port-labs/port-k8s-exporter/actions/runs/18627902414/artifacts/4310299388Code Coverage Total Percentage:
|
Code Coverage Artifact 📈: https://github.com/port-labs/port-k8s-exporter/actions/runs/18627964386/artifacts/4310312203Code Coverage Total Percentage:
|
Code Coverage Artifact 📈: https://github.com/port-labs/port-k8s-exporter/actions/runs/18631549735/artifacts/4311186468Code Coverage Total Percentage:
|
Code Coverage Artifact 📈: https://github.com/port-labs/port-k8s-exporter/actions/runs/18675939846/artifacts/4325076591Code Coverage Total Percentage:
|
This reverts commit d14d5b8.
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Code Coverage Artifact 📈: https://github.com/port-labs/port-k8s-exporter/actions/runs/18719383128/artifacts/4341073600Code Coverage Total Percentage:
|
Code Coverage Artifact 📈: https://github.com/port-labs/port-k8s-exporter/actions/runs/18719568740/artifacts/4341674172Code Coverage Total Percentage:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What - Introduced a way to control the list of env vars that the pod is able to get
Why - Allow clients to be able to restrict the pod from returning env vars
How - Introducing AllowedEnvironmentVariablesInJQ (list of whitelisted env vars) + AllowEnvironmentVariablesInJQ (true/false) that will be available to usage both at setup from the cli and in the mapping
Type of change
Please leave one option from the following and delete the rest: