Release 0.21.16 (982)

[Natrinicle]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

Fix regex extractor using upstream cherry-picked version change to NewPipeExtractor

Fixes the following issue(s)

• Fixes No Video Will play (any video) TeamNewPipe/NewPipe#7734

Relies on the following changes

• Regex error when parsing the Youtube JavaScript code TeamNewPipe/NewPipeExtractor#785

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

• I read the contribution guidelines.

[connectety]

Looking at the original commit, the bump of the extractor is missing.
TeamNewPipe@4e63350#diff-51a0b488f963eb0be6c6599bf5df497313877cf5bdff3950807373912ac1cdc9R192

[Natrinicle]

Looking at the original commit, the bump of the extractor is missing. TeamNewPipe@4e63350#diff-51a0b488f963eb0be6c6599bf5df497313877cf5bdff3950807373912ac1cdc9R192

Thanks for catching that! I completely missed that the original PR was 2 commits

[dbenjaminmiller]

I don't see anything under checks. Can you attach the debug APK to the issue?

[Natrinicle]

I don't see anything under checks. Can you attach the debug APK to the issue?

I didn't build the application, just copied the PR from upstream. The upstream checks are available at: https://github.com/TeamNewPipe/NewPipe/actions/runs/1778307716 and the upstream debug apk is available https://github.com/TeamNewPipe/NewPipe/suites/5135783348/artifacts/154726306.

[dbenjaminmiller]

Thanks, got it now!

[Atemu]

Please just merge master rather than cherry-picking the commits.

[Natrinicle]

Please just merge master rather than cherry-picking the commits.

Like this @Atemu?

[Atemu]

Yup. Though @polymorphicshade will probably just merge master into our master themselves.

[Coderdude112]

Any update on this PR @polymorphicshade? This fork is basically useless until TeamNewPipe#7734 is fixed here.

[HairyMilkshakes]

Any update on this PR @polymorphicshade? This fork is basically useless until TeamNewPipe#7734 is fixed here.

Just patiently wait. I am sure this will be addressed by tomorrow. In the meantime use a browser with uBlock extension :)

[polymorphicshade]

Thanks for the pull request, however I much prefer to do the merge/rebasing myself.
Sorry for the delay, I've been dealing with bad health issues these past 2 weeks.

[FarisZR]

Quick question, the repo shows the last commit is from before 4 days ago, even though the latest newpipe release is only 2 days ago.
Is the source code merge/PR not pushed to github ?

[Atemu]

Um yeah, you forgot to push the merge @polymorphicshade...

^^'

[h4xor666]

Guys they said they're having health issues, maybe lay off for a bit?

[FarisZR]

Sure it was just a question. However this is a license violation of the GPL.

…

-------- Original Message --------

On Feb. 3, 2022, 7:34 p.m., polymorphicshade/NewPipe - reply+aipxadqeyyjy22bzcokn2awaa7sqhevbnhheftglhi at reply.github.com wrote: Guys they said they're having health issues, maybe lay off for a bit? — Reply to this email directly, [view it on GitHub](#128 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AIPXADWIJGQNFMLAM5355R3UZKVAHANCNFSM5NJHRTBA). Triage notifications on the go with GitHub Mobile for [iOS](https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675) or [Android](https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub). You are receiving this because you commented.Message ID: ***@***.***>

[polymorphicshade]

@Atemu yup I totally forgot to push. I guess that's what happens when I'm doped up on pain meds and having no sleep for 4 days... The release should be pointed to the right commit now.
@h4xor666 it's ok they are just letting me know. I take no offense.

[Atemu]

Oh boy, I hope you recover soon @polymorphicshade!

[Natrinicle]

@polymorphicshade Let us know if there's anything we can do to help.

Maintaining a project is not an easy task and I didn't want to come across as demanding which is why I tried to let you know about the upstream patch in as helpful a way as I could think of. If you'd prefer something like a bug report in the issues or some other method please let me know and I'd be happy to modify future requests.