Skip to content

Swift 3 Renaming #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 9, 2016
Merged

Swift 3 Renaming #5

merged 6 commits into from
Dec 9, 2016

Conversation

bcylin
Copy link
Collaborator

@bcylin bcylin commented Dec 1, 2016

  • Follow the Swift guideline to rename some of the methods
  • Use the background image view as the receiver instead of using another wrapper to perform methods after delay
  • Fix the background image transition cancelling by replacing cancelPreviousPerformRequests(withTarget:selector:object:) with cancelPreviousPerformRequests(withTarget:)

@polydice/ios could you please take a look at these changes? thanks!

@codecov-io
Copy link

Current coverage is 33.89% (diff: 38.29%)

Merging #5 into develop will increase coverage by 20.17%

@@            develop         #5   diff @@
==========================================
  Files            43         43          
  Lines          1363       1360     -3   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            187        461   +274   
+ Misses         1176        899   -277   
  Partials          0          0          

Powered by Codecov. Last update d2d1284...d6339e4

@bcylin bcylin requested review from dlackty and czars December 8, 2016 11:01
@bcylin bcylin merged commit d6339e4 into develop Dec 9, 2016
bcylin added a commit that referenced this pull request Dec 9, 2016
Merge branch 'feature/renaming' into develop
@bcylin bcylin deleted the feature/renaming branch December 9, 2016 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants