Fix length checking overflow in EVM revert reason parsing #820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boundless-forest
pushed a commit
to darwinia-network/frontier
that referenced
this pull request
Aug 15, 2022
…vm#820) * Fix length checking overflow in EVM revert reason parsing * Remove unused debug_assert
nanocryk
pushed a commit
to moonbeam-foundation/frontier
that referenced
this pull request
Aug 16, 2022
…vm#820) * Fix length checking overflow in EVM revert reason parsing * Remove unused debug_assert
abhijeetbhagat
pushed a commit
to web3labs/frontier
that referenced
this pull request
Jan 11, 2023
…vm#820) * Fix length checking overflow in EVM revert reason parsing * Remove unused debug_assert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current code in parsing the EVM revert reason is incorrect in two ways. First, the length is a big-endian encoded U256, not a simple sum. Second, the current summing function uses the accumulator type of
u8which will overflow easily. The current code only works because most EVM revert reasons are not larger than 256 bytes.