Maven plugin descriptor contains javadoc taglets

[kwin]

The Maven plugin descriptor (in META-INF/maven/plugin.xml) incorrectly contains javadoc taglets which leads to the following code completion hover in m2e:

This can be fixed by upgrading to a newer version of the maven-plugin-plugin (

forbidden-apis/build.xml

Line 114 in b58e15c

<property name="maven-plugin-plugin.version" value="3.4"/>

) which fixed this: https://issues.apache.org/jira/browse/MPLUGIN-298 and https://issues.apache.org/jira/browse/MPLUGIN-417. Further details in https://maven.apache.org/plugin-tools/#plugin-descriptors.

[uschindler]

OK, can check this.

This is not a serious issue, it is just that your UI prints javadoc syntax in the hover, correct?

[kwin]

This also affects e.g. help given out via https://maven.apache.org/plugins/maven-help-plugin/describe-mojo.html but agree this is just a minor issue.

[uschindler]

OK,
I was trying to update the plugin-plugin to the minimum version that fixes the issue, but this caused:

[artifact:mvn] [main] ERROR org.apache.maven.cli.MavenCli - Failed to execute goal org.apache.maven.plugins:maven-plugin-plugin:3.7.0:helpmojo (default-cli) on project forbiddenapis: The plugin org.apache.maven.plugins:maven-plugin-plugin:3.7.0 requires Maven version 3.2.5 -> [Help 1]

I also tried latest version of the plugin-plugin but this had different task names. It is also no longer compatible with older Java versions (I think).

So it needs a bit more work to fix this, but will work on it.

[uschindler]

I was able to fix it:

 build.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/build.xml b/build.xml
index da8e2aa..ebf95d0 100644
--- a/build.xml
+++ b/build.xml
@@ -110,8 +110,8 @@
 
   <property name="jdk.version" value="1.7"/>
   <property name="min.maven.version" value="3.1.0"/>
-  <property name="maven.version" value="3.1.1"/><!-- used for testing -->
-  <property name="maven-plugin-plugin.version" value="3.4"/>
+  <property name="maven.version" value="3.2.5"/><!-- used for testing -->
+  <property name="maven-plugin-plugin.version" value="3.7.0"/>
   <property name="maven-compiler-plugin.version" value="3.8.1"/>
   
   <!-- extra properties (prefixed by "gradle." added to gradle.properties during testing: -->

After that the plugin-help.xml no longer contains those javadoc artifacts:

I still need to carefully restore the minimum Maven version, because it is also used for testing and I want to test the "real minimum".

So I will execute the descriptor build possibly on a later maven version.

Thansk for reporting the issue, I have seen this long ago (arozund 2012) when I worked on the Maven code, but I was not sure if the help file rwquires plain text or not.

[uschindler]

But the fix needs Java 8, so I will do this soon (the upgrade was planned already, damn....!).

Putting that issue on delay.

[uschindler]

Sorry, I also looked at wrong file. The plugin descriptor contains those javadocs snippets. But yes, using the later plugin verison fixes the issue in both files.

[uschindler]

Why does the IDE uses the plugin descriptor and not plugin-help.xml? The latter is correct also in the current version.

[uschindler]

To conclude on the problem:

• The plugin descriptor plugin.xml contains HTML code which has the issue.
• The plugin-help.xml is not affected, so if the IDE would use that one, I won't be affected

The issue is cosmetic only.