-
Notifications
You must be signed in to change notification settings - Fork 24
AMD Ready, Package.json and minor optimization #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Using this method: http://stackoverflow.com/a/11890239/641755
…dren on each and every scroll event
Many thanks! Looks great. |
Hey again, I actually removed that ".sticky" part because I didn't know what it did. Looking through the jquery.com docs didn't help me much, so I figured it was something to do with the old However, I just looked through the jQuery source and it turns out it's namespacing for events (If I'm correct), which is pretty cool. Thanks for the tip! I pushed another commit and it looks like that attached itself to the pull request automatically |
Oh, and regarding the example: I made it so that the only thing that is pulled down by package managers is I think for people going to GitHub and clicking the "download zip" button, it's nice to have an example you can open up and copy/paste the code from. |
Yep, namespacing events is really handy! And thanks for explaining your thoughts on the example — let's keep it in! It seems that the tests are currently broken #9 so I can’t verify that everything works, but that has nothing to do with your changes. I’ll try to fix them and then merge the PR. Would you mind documenting the AMD support in the README? We might also be able remove the examples from there as we now have the example directory. Many thanks again! |
Hey Florian,
As the title suggests, I added a few extra things to your otherwise great jQuery plugin.
<ul>
and<ol>
elements.