[Building Sync-ups Tutorial] fixes in "Editing and deleting a sync-up" chapter #3578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update view code files to use the newer `.clipShape(.rect(cornerRadius:))` modifier instead of the deprecated `.cornerRadius()` method
… role - Replace deprecated `.foregroundColor()` with `.foregroundStyle()` - Add `.destructive` role to delete button - Remove explicit `.foregroundColor(.red)` styling for the delete button - Replace `.accentColor` with `Color.accentColor` in foregroundStyle modifier for tutorial code files to fix compilation error "type 'ShapeStyle' has no member 'accentColor'"
Use `withLock` to safely update the shared `syncUp` state when editing a sync-up in the tutorial code files
Refactor SyncUpDetail reducer to: - Use type-safe `.syncUps` key for shared state - Implement thread-safe state mutation with `withLock`
Modify tutorial documentation to: - Simplify explanation of `.run` effect - Remove unnecessary commentary about sending delegate action which are no longer done with the usage of `@Shared`
Minor code cleanup by removing an extra blank line in the SyncUpDetail reducer that was causing weird diff in the tutorial
FredericRuaudel
commented
Feb 1, 2025
Comment on lines
30
to
31
| @Shared(.fileStorage(.syncUps)) var syncUps: IdentifiedArrayOf<SyncUp> = [] | ||
| syncUps.remove(id: state.syncUp.id) | ||
| return .none | ||
| // @Shared(.fileStorage(.syncUps)) var syncUps: IdentifiedArrayOf<SyncUp> = [] | ||
| @Shared(.syncUps) var syncUps |
There was a problem hiding this comment.
📓 Here I've added a new step to suggest the usage of the typesafe shared key instead of the "basic" .fileStorage syntax. And due to that, as with one of my previous PR, the next diffs will be weird due to the shift of the files numbering.
FredericRuaudel
commented
Feb 1, 2025
Comment on lines
271
to
277
| @Step { | ||
| We can also use the type safe key `.syncUps` we have created earlier to ensure the | ||
| type and key are correct and we get a more consise declaration as a bonus. | ||
|
|
||
| @Code(name: "SyncUpDetail.swift", file: EditingAndDeletingSyncUp-02-code-0011.swift) | ||
| } | ||
|
|
There was a problem hiding this comment.
📓 Here is the new step to suggest the usage of the typesafe key.
FredericRuaudel
commented
Feb 1, 2025
Comment on lines
-311
to
+321
| ``ComposableArchitecture/Send`` for sending actions back into the system. | ||
| ``ComposableArchitecture/Send`` for sending actions back into the system if needed. |
There was a problem hiding this comment.
📓 Here I've added "if needed" because the run action has only the call to the dismiss dependency while before there was also the sending of the delegate action. So now, the send is not really needed, hence the update…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Following my last PR, I'm currently reviewing the "Building Sync-ups" tutorial and so far, there is a lot of changes so I've splitted up into one PR per chapter to ease the review of them, continuing with the "Editing and deleting a sync-up" chapter here…
Changes Made:
.cornerRadius()method with the newer.clipShape(.rect(cornerRadius:))modifier to ensure compatibility with the latest SwiftUI standards..destructiverole instead of.foregroundColor(.red)for better semantics.withLockto ensure safe updates to the sharedsyncUpstate during editing.SyncUpDetailtutorial to utilize a type-safe.syncUpskey when updating the parent list after deletion confirmation action.