Skip to content

Fix typos in Store.swift #3547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Conversation

jphong1005
Copy link
Contributor

Hello, I modified the code for the readability of the function.
Please review the changes, Thanks! 😄

Detail: Fix formatting by removing extra space before 'public'. (#Line: 335)

  • origin code

    public
        func scope<ChildState, ChildAction>(
  • changed code

    public func scope<ChildState, ChildAction>(

Fix formatting by removing extra space before 'public'.
@stephencelis
Copy link
Member

@Benedicto-H Thanks for taking the time to PR, but we actually use swift-format to automatically format this source code, and for whatever reason it decides to format it this way. If we merged this PR it would automatically get reformatted back 😅

Going to close this, but thanks again!

@jphong1005
Copy link
Contributor Author

@stephencelis Oh! You were using a format tool called swift-format 😅
Thanks to you, I learned something new. Thank you for letting me know.

@bugix
Copy link
Contributor

bugix commented Jan 8, 2025

Not to waste anyones time, but my local swift-format from xcode 16.2 works fine after manually removing the linebreak in question.

swift-format.patch

@stephencelis
Copy link
Member

I'll merge just in case, but if it reverts back then we'll leave it be.

@stephencelis stephencelis reopened this Jan 9, 2025
@stephencelis stephencelis merged commit eab3982 into pointfreeco:main Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants