Add support for Swift 6.1 trailing commas #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @brzzdev, thanks for this! Could you add a test showing the behavior too? |
|
@mbrandonw Added! Like I mentioned, I wanted to add them initially but I was getting errors building the tests last night. A |
|
Oops sorry, breezed past that part. The error could have also been due to using pre-compiled SwiftSyntax if you have that enabled. I think they are still working on that bug. |
mbrandonw
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out the issue was actually coming from swift-case-paths.
I would've added tests, but the MacroTests don't seem to be building. Not sure if that's a me problem, or a know problem.