Skip to content

Incorrect values in sample.json for sample react-application-m365-service-health #1510

@Saurabh7019

Description

@Saurabh7019

Sample

https://github.com/pnp/sp-dev-fx-extensions/tree/main/samples/react-application-m365-service-health

Author(s)

@joaojmendes

What happened?

The following fields in samples/react-application-m365-service-health/assets/sample.json still have placeholder values:

Image

this is a minor issue but it's more prominent in the SPFx Toolkit's sample gallery which consumes these metadata to display samples. Because of the incorrect name and URL this sample appears broken in the sample gallery.

Image

Steps to reproduce

NA

Expected behavior

The sample.json should have a valid name and URL matching the sample folder path.

Target SharePoint environment

SharePoint Online

Developer environment

None

Browsers

  • Internet Explorer
  • Microsoft Edge
  • Google Chrome
  • FireFox
  • Safari
  • mobile (iOS/iPadOS)
  • mobile (Android)
  • not applicable
  • other (enter in the "Additional environment details" area below)

Node.js version

v22.16.0

Additional environment details

No response

Metadata

Metadata

Assignees

Labels

Needs: Triage 🔍type:bug-suspectedSuspected bug (not working as designed/expected). See type:bug-confirmed for confirmed bugs

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions