Skip to content

Second #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 12, 2025
Merged

Second #93

merged 5 commits into from
Apr 12, 2025

Conversation

Mmbr1606
Copy link
Contributor

@Mmbr1606 Mmbr1606 commented Apr 3, 2025

from other branch

@Laskewitz Laskewitz self-requested a review April 12, 2025 11:55
Copy link
Member

@Laskewitz Laskewitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the suggested changes and I'll be able to approve and merge it! 🙂

"gitHubAccount": "summitbaj",
"name": "Summit Bajracharya",
"pictureUrl": "https://github.com/summitbaj.png"
"gitHubAccount": "mmbr1606",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're changing the sample.json prompt that someone else submitted to your details. That doesn't make any sense. Can you please change this back to the original value?


**THIS CODE IS PROVIDED *AS IS* WITHOUT WARRANTY OF ANY KIND, EITHER EXPRESS OR IMPLIED, INCLUDING ANY IMPLIED WARRANTIES OF FITNESS FOR A PARTICULAR PURPOSE, MERCHANTABILITY, OR NON-INFRINGEMENT.**

<img src="https://m365-visitor-stats.azurewebsites.net/powerplatform-prompts/samples/ai-builder/sample" aria-hidden="true" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be changed to <img src="https://m365-visitor-stats.azurewebsites.net/powerplatform-prompts/prompts/power-apps/rental-property-inspection" aria-hidden="true" />

@@ -0,0 +1,32 @@
# YOUR PROMPT NAME
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this to # Inspection Approval Assignment


**THIS CODE IS PROVIDED *AS IS* WITHOUT WARRANTY OF ANY KIND, EITHER EXPRESS OR IMPLIED, INCLUDING ANY IMPLIED WARRANTIES OF FITNESS FOR A PARTICULAR PURPOSE, MERCHANTABILITY, OR NON-INFRINGEMENT.**

<img src="https://m365-visitor-stats.azurewebsites.net/powerplatform-prompts/samples/ai-builder/sample" aria-hidden="true" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this to <img src="https://m365-visitor-stats.azurewebsites.net/powerplatform-prompts/prompts/power-apps/inspection-approval-assignment" aria-hidden="true" />

"version": "1.0.0.0",
"source": "pnp",
"creationDateTime": "2025-04-02T00:00:00.000Z",
"updateDateTime": "2023-04-02T00:00:00.000Z",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the date to "updateDateTime": "2025-04-02T00:00:00.000Z",

@@ -1,3 +0,0 @@
# Power Pages Prompts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove the Power Pages readme? This shouldn't be deleted.

@@ -0,0 +1,31 @@
# YOUR PROMPT NAME
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to # Rental Property Listing


**THIS CODE IS PROVIDED *AS IS* WITHOUT WARRANTY OF ANY KIND, EITHER EXPRESS OR IMPLIED, INCLUDING ANY IMPLIED WARRANTIES OF FITNESS FOR A PARTICULAR PURPOSE, MERCHANTABILITY, OR NON-INFRINGEMENT.**

<img src="https://m365-visitor-stats.azurewebsites.net/powerplatform-prompts/samples/ai-builder/sample" aria-hidden="true" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to <img src="https://m365-visitor-stats.azurewebsites.net/powerplatform-prompts/prompts/power-pages/rental-property-listing" aria-hidden="true" />

@Mmbr1606
Copy link
Contributor Author

@Laskewitz

Thank you Daniel for reviewing, i made the changes and commited as suggested. Everything should be on track now.

thanks for reviewing again

Copy link
Member

@Laskewitz Laskewitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good! Merging now! Thank you for your contributions!

@Laskewitz Laskewitz merged commit b8433ca into pnp:main Apr 12, 2025
1 check passed
@Mmbr1606
Copy link
Contributor Author

thanks for checking again so quickly and sorry for the little messup, lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants