Skip to content

Optimize 2 more lines in the KroneckerEK0 #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 15, 2021
Merged

Optimize 2 more lines in the KroneckerEK0 #107

merged 2 commits into from
Sep 15, 2021

Conversation

nathanaelbosch
Copy link
Collaborator

Another super small PR that just improves an individual computation in the algorithm.

pnkraemer
pnkraemer approved these changes Sep 15, 2021
View reviewed changes
Copy link
Owner

@pnkraemer pnkraemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat. I have a feeling one can compute the product of the rows before applying P[1,1] to save another micro-amount of computation, but I dont think this makes too much of a difference :)

@nathanaelbosch nathanaelbosch removed the request for review from schmidtjonathan September 15, 2021 17:06
@nathanaelbosch
Copy link
Collaborator Author

I adjusted these lines and I'd hope they are a tiny bit faster now :)

@nathanaelbosch nathanaelbosch merged commit f952800 into main Sep 15, 2021
@nathanaelbosch nathanaelbosch deleted the nb/more-kroneckerek0-optimizations branch September 15, 2021 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnkraemer pnkraemer pnkraemer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nathanaelbosch @pnkraemer