Skip to content

Enable scalar error estimates and use them in the KroneckerEK0 #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2021
Merged

Enable scalar error estimates and use them in the KroneckerEK0 #106

merged 1 commit into from
Sep 15, 2021

Conversation

nathanaelbosch
Copy link
Collaborator

Removing the jnp.stack(...) part greatly improves the jax jit compilation times!

pnkraemer
pnkraemer approved these changes Sep 15, 2021
View reviewed changes
Copy link
Owner

@pnkraemer pnkraemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I wasnt aware of the stack there before, but in any case it is great to gain some speed this way :)

@nathanaelbosch nathanaelbosch merged commit 66610f8 into main Sep 15, 2021
@nathanaelbosch nathanaelbosch deleted the nb/enable-scalar-errorestimates branch September 15, 2021 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnkraemer pnkraemer pnkraemer approved these changes

@schmidtjonathan schmidtjonathan Awaiting requested review from schmidtjonathan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nathanaelbosch @pnkraemer