New examples structure #246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
saitonakamura
commented
Feb 28, 2023
saitonakamura
commented
- Reinterpreted structure from react-three-fiber/examples
- Used vanilla-extract instead of styled component
- XR examples is more standalone and ready for copy-paste
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0db0e68:
|
saitonakamura
force-pushed
the
new-examples
branch
from
00f4e43 to
2f7ef9c
Compare
* Reinterpreted structure from [react-three-fiber/examples](https://github.com/pmndrs/react-three-fiber/blob/master/example/src/App.tsx) * Used vanilla-extract instead of styled component * XR examples is more standalone and ready for copy-paste
saitonakamura
force-pushed
the
new-examples
branch
from
c8611a3 to
0db0e68
Compare
|
Tested the new examples on Meta Quest 2 and AR on Samsung Galaxy S21 |
|
Hey, I decided to merge it now, but if you have any feedback, just let me know |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.